Deselecting first message of collapsed thread does not deselect children #3978

Closed
rcubetrac opened this Issue Oct 23, 2012 · 8 comments

2 participants

@rcubetrac

Reported by dj1yfk on 23 Oct 2012 20:29 UTC as Trac ticket #1488772

When selecting a range of messages in the message list (by first clicking one single message, and then clicking on another one below or above, while holding down Shift), collapsed threads (with all of their children) that are somewhere within this range appear as selected and if an action is performed, e. g. deleting the selected range of messages, the whole thread is deleted, as expected.

If now, after selecting such a range, I deselect a collapsed thread by clicking the first (and only visible) message of it while holding down Ctrl, it appears that actually only this very first message of the thread is deselected. If I now press "Delete" only the first message of this thread survives, the children are still selected and are deleted. I'd have expected that the children are also deselected.

Tested with the latest version on demo.roundcube.net (0.8.2) and verified on 0.7.2 too (IE8, Firefox 16.0.1)

Keywords: threads, selection, children
Migrated-From: http://trac.roundcube.net/ticket/1488772

@rcubetrac

Milestone changed by @alecpl on 19 Nov 2012 08:26 UTC

later => 0.9-beta

@rcubetrac

Owner changed by @alecpl on 20 Nov 2012 07:49 UTC

=> alec

@rcubetrac

Comment by @alecpl on 20 Nov 2012 08:57 UTC

Fixed in 2b55d4f

@rcubetrac

Status changed by @alecpl on 20 Nov 2012 08:57 UTC

new => closed

@rcubetrac

Comment by maharaja on 27 Nov 2012 15:41 UTC

i think this commit broke the deletion of collapsed threads, at least for 0.8.

reverting to commit a0682b5 restores the functionality.

cheers,
raoul

@rcubetrac

Status changed by maharaja on 27 Nov 2012 15:41 UTC

closed => reopened

@rcubetrac

Comment by @alecpl on 27 Nov 2012 17:09 UTC

Fixed in 8beceeb.

@rcubetrac

Status changed by @alecpl on 27 Nov 2012 17:09 UTC

reopened => closed

@rcubetrac rcubetrac closed this Nov 27, 2012
@alecpl alecpl was assigned by rcubetrac Mar 20, 2016
@rcubetrac rcubetrac added this to the 0.9-beta milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment