Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred email address support #4187

Closed
rcubetrac opened this issue May 5, 2013 · 7 comments
Closed

Preferred email address support #4187

rcubetrac opened this issue May 5, 2013 · 7 comments

Comments

@rcubetrac
Copy link

@rcubetrac rcubetrac commented May 5, 2013

Reported by @alecpl on 5 May 2013 11:08 UTC as Trac ticket #1489083

We currently support "home", "work", "other". However vCard and some csv imports can contain emails marked as preferred (PREF). In such case the email is displayed as "other". As simple patch to rcube_vcard fixes preferred address import from csv:

--- a/program/lib/Roundcube/rcube_vcard.php
+++ b/program/lib/Roundcube/rcube_vcard.php
@@ -194,7 +194,7 @@ class rcube_vcard
                             $subtype = strtolower($raw[                        }

-                        while ($k < count($raw['type']('type'][$k]);
)) && ($subtype == 'internet' || $subtype == 'pref')) {
+                        while ($k < count($raw[&& ($subtype == 'internet' || $subtype == 'pref')) {
                             $subtype = $typemap[$raw['type']('type'])-1)[? $typemap[$raw['type'](++$k]])[: strtolower($raw['type']($k]])[$k]);
                         }
                     }

(that might be not complete) but then the address is not displayed in the UI. We need to support "pref" type at least in addressbook/func.inc.

Migrated-From: http://trac.roundcube.net/ticket/1489083

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 1, 2013

Milestone changed by @alecpl on 1 Dec 2013 10:02 UTC

1.0-beta => 1.0-stable

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Jan 20, 2014

Comment by @thomascube on 20 Jan 2014 11:19 UTC

If we support that property, the UI has to support it as well. Re-scheduling...

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Jan 20, 2014

Milestone changed by @thomascube on 20 Jan 2014 11:19 UTC

1.0-stable => 1.1-beta

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Aug 18, 2014

Comment by @thomascube on 18 Aug 2014 06:33 UTC

Rescheduling...

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Aug 18, 2014

Milestone changed by @thomascube on 18 Aug 2014 06:33 UTC

1.1-beta => 1.2-beta

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Sep 10, 2015

Comment by @alecpl on 10 Sep 2015 08:03 UTC

I wasn't so interested in full preferred address support. There was a bug in csv import that caused such addresses to be not imported at all. I can't reproduce it anymore.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Sep 10, 2015

Status changed by @alecpl on 10 Sep 2015 08:03 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.