php_admin_value error_reporting 30711 #4331

Closed
rcubetrac opened this Issue Sep 6, 2013 · 4 comments

Comments

Projects
None yet
1 participant

Reported by mal on 6 Sep 2013 12:08 UTC as Trac ticket #1489323

If "php_admin_flag error_reporting 30711" is used in a virtual host's configuration to set the correct error_reporting value for Roundcube, Roundcube 0.9.3 fails in bootstrap.php because it is not reading the actual value of error_reporting, thanks to using filter_var(..., FILTER_VALIDATE_BOOLEAN). Because php_admin_value was used to set error_reporting, Roundcube's call to ini_set() fails and Roundcube assumes an incorrect error_reporting value.

Roundcube does not need to call ini_set in this case, since error_reporting is already the desired value of 30711.

The only solution on a shared server where error_reporting in php.ini is NOT 30711, is to set it under the virtual host and this is failing with 0.9.3 and worked with 0.9.2

Migrated-From: http://trac.roundcube.net/ticket/1489323

Comment by @alecpl on 6 Sep 2013 12:33 UTC

We should use FILTER_VALIDATE_INT for "integer options".

Milestone changed by @alecpl on 6 Sep 2013 12:33 UTC

later => 0.9.5

Comment by @alecpl on 6 Sep 2013 16:49 UTC

Fixed in 3d5eea7.

Status changed by @alecpl on 6 Sep 2013 16:49 UTC

new => closed

rcubetrac closed this Sep 6, 2013

rcubetrac added this to the 0.9.5 milestone Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment