Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing categories/groups in vCard export #4766

Closed
rcubetrac opened this issue Feb 16, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@rcubetrac
Copy link

commented Feb 16, 2015

Reported by @alecpl on 16 Feb 2015 08:14 UTC as Trac ticket #1490277

When using the sql addressbook we assign a group to a contact the internal representation of vCard data is not updated. The same when the assignment is being deleted. This is the reason why contact export contains invalid CATEGORIES.

A solution to this could be CATEGORIES entry update in export.inc (prepare_for_export() function).

Migrated-From: http://trac.roundcube.net/ticket/1490277

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 16, 2015

Comment by @alecpl on 16 Feb 2015 08:28 UTC

Oh, I see the code is already there (in prepare_for_export), but it does not update existing CATEGORIES entry. So, we should fix this here and maybe remove CATEGORIES when the vcard data is saved into database (or on contact import?).

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 22, 2015

Comment by @alecpl on 22 Feb 2015 09:49 UTC

Fixed in bd82526.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 22, 2015

Status changed by @alecpl on 22 Feb 2015 09:49 UTC

new => closed

@rcubetrac rcubetrac closed this Feb 22, 2015

@rcubetrac rcubetrac added this to the 1.1.1 milestone Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.