Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function in SMTP files #4770

Closed
rcubetrac opened this issue Feb 18, 2015 · 26 comments

Comments

Projects
None yet
5 participants
@rcubetrac
Copy link

commented Feb 18, 2015

Reported by youngrp on 18 Feb 2015 02:16 UTC as Trac ticket #1490281

It's my first ticket here so I don't know if I filled the form correctly. Follow the log lines:

[23:41:43](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 448
[23:41:43](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 465
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 472
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 515
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 519
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/program/lib/Roundcube/rcube_smtp.php on line 129
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/program/lib/Roundcube/rcube_smtp.php on line 243
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 945
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 948
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/program/lib/Roundcube/rcube_smtp.php on line 255
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/program/lib/Roundcube/rcube_smtp.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 975
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 978
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/program/lib/Roundcube/rcube_smtp.php on line 291
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 1054
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 1057
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 1117
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 1127
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 1132
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 489
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 263
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 492
[23:41:44](17-Feb-2015) PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /path/to/webmail/vendor/pear/net_smtp/Net/SMTP.php on line 495

Thanks.

Keywords: Deprecated PEAR SMTP
Migrated-From: http://trac.roundcube.net/ticket/1490281

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 18, 2015

Comment by @alecpl on 18 Feb 2015 07:05 UTC

For Net_SMTP: pear/Net_SMTP#12. For Roundcube we should fix this. Anyway, should not error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT (as we do in bootstrap.php) make these warnings to not appear in the log?

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 18, 2015

Milestone changed by @alecpl on 18 Feb 2015 07:05 UTC

later => 1.1.1

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 26, 2015

Comment by @alecpl on 26 Feb 2015 17:04 UTC

Roundcube code fixed in b59b72c.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Feb 26, 2015

Status changed by @alecpl on 26 Feb 2015 17:04 UTC

new => closed

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Comment by rndcy on 12 May 2015 07:08 UTC

Hi! It seems to be indeed fixed (most logs disappeared), but not everywhere. It still happens (after upgrade to version 1.1.1 of a manually installed Roundcube on Debian Jessie, behind stunnel and nginx):

-- /var/log/nginx/access.log:

xx.xx.xx.xx - - [+0200](11/May/2015:12:02:51) "POST /rc/?_task=mail&_unlock=loading1431338568999&_lang=fr&_framed=1 HTTP/1.1" 200 365 "https://example.org/rc/?_task=mail&_action=compose&_id=204345685055507dddbddc7&_extwin=1" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0"

-- /var/log/messages:

May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 448
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 465
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 472
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 515
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 519
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 945
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 948
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 975
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 978
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 975
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 978
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 1054
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 1057
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 1117
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 1127
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:49 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 1132
May 11 12:02:51 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 489
May 11 12:02:51 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 263
May 11 12:02:51 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 492
May 11 12:02:51 server roundcube: PHP Deprecated:  Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /var/www/roundcubemail-1.1.1/vendor/pear/net_smtp/Net/SMTP.php on line 495
@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Status changed by rndcy on 12 May 2015 07:08 UTC

closed => reopened

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Comment by @alecpl on 12 May 2015 07:20 UTC

As I said we'll not modify Net_SMTP code. Change your error_reporting setting.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Status changed by @alecpl on 12 May 2015 07:20 UTC

reopened => closed

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Comment by @thomascube on 12 May 2015 07:22 UTC

We removed the copies of PEAR libraries in favor of pulling them in from the original source. These fixes therefore need to go upstream to the Net_SMTP library. Please create a ticket at https://github.com/pear/Net_SMTP

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 12, 2015

Comment by @thomascube on 12 May 2015 07:23 UTC

Oops, there it is already: pear/Net_SMTP#12

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 14, 2015

Comment by uncle fu on 14 May 2015 11:20 UTC

This issue is fixed in NET_SMTP2.
Installing the NET_SMTP2 package and changing rcube_smtp.php accordingly (@line 111) did solve this problem for me.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented May 15, 2015

Comment by @thomascube on 15 May 2015 09:41 UTC

I just create a feature request ticket to consider Net_SMTP2 for Roundcube: #1490394

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jun 25, 2015

Comment by sthen on 25 Jun 2015 12:12 UTC

The "error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT" setting in bootstrap.php does not mask out the deprecation warnings, at least in the PHP version I tested with (5.6.10), and this overrides user-set values in php.ini.

Until/if Net_SMTP2 is used, I think it would make sense to change bootstrap.php to use "error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED" which does avoid filling logs.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jun 25, 2015

Status changed by sthen on 25 Jun 2015 12:12 UTC

closed => reopened

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jun 26, 2015

Comment by @alecpl on 26 Jun 2015 06:19 UTC

Ok, let's change error_reporting in 1.1 and for 1.2 we should probably switch to Net_SMTP2.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jun 26, 2015

Milestone changed by @alecpl on 26 Jun 2015 06:19 UTC

1.1.1 => 1.1.3

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 31, 2015

Comment by @alecpl on 31 Jul 2015 11:17 UTC

Done for 1.1 in fe82e21. We'll work for a real fix in git-master.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 31, 2015

Status changed by @alecpl on 31 Jul 2015 11:17 UTC

reopened => closed

@rcubetrac rcubetrac closed this Jul 31, 2015

@rcubetrac rcubetrac added this to the 1.1.3 milestone Mar 20, 2016

@skiner68

This comment has been minimized.

Copy link

commented Sep 6, 2016

I think this is still not solved - I have just made a fresh new installlation of 1.2.1, error log is still full.

@alecpl

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

Just use PEAR-1.10.x

@skiner68

This comment has been minimized.

Copy link

commented Sep 6, 2016

Thanks for your reply. But - should not proper versions of external packages be part of complete RC download package? :-/ https://roundcube.net/download/

@alecpl

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

And they are, but maybe in case of PEAR it is loaded somehow from your system? Or if you upgraded from old program/lib directory content.

@skiner68

This comment has been minimized.

Copy link

commented Sep 6, 2016

Thanks a lot! I have already checked my installation, but I will go deeper.

@texxasrulez

This comment has been minimized.

Copy link

commented Sep 25, 2016

I have the same problem and it is a fresh install of RC 1.2.1 to an empty directory. No plugins enabled and I get this in my error log:
[25-Sep-2016 10:54:47 America/Chicago] PHP Deprecated: Non-static method Auth_SASL::factory() should not be called statically, assuming $this from incompatible context in /var/www/virtual/genesworld.net/htdocs/mail/program/lib/Roundcube/rcube_imap_generic.php on line 578
[25-Sep-2016 10:54:47 America/Chicago] PHP Deprecated: Non-static method Auth_SASL::factory() should not be called statically, assuming $this from incompatible context in /path-to-roundcube/program/lib/Roundcube/rcube_imap_generic.php on line 578
[25-Sep-2016 10:54:47 America/Chicago] PHP Deprecated: Non-static method Auth_SASL::factory() should not be called statically, assuming $this from incompatible context in /path-to-roundcube/program/lib/Roundcube/rcube_imap_generic.php on line 578

I do have error reporting turned off and I still get a log full of errors ...

Thank you for your work ..

@mercury1337

This comment has been minimized.

Copy link

commented Dec 31, 2016

I am also getting this message on 1.2.3:

[31-Dec-2016 15:45:02 Europe/Berlin] PHP Deprecated: Non-static method Auth_SASL::factory() should not be called statically in /var/www/html/rc/vendor/pear-pear.php.net/Net_SMTP/Net/SMTP.php on line 704

@alecpl

This comment has been minimized.

Copy link
Member

commented Dec 31, 2016

@mercury1337 This is Net_SMTP bug already fixed in git but not released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.