Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installer aware we do not support PHP7 (yet) #4908

Closed
rcubetrac opened this issue Sep 21, 2015 · 9 comments

Comments

Projects
None yet
1 participant
@rcubetrac
Copy link

commented Sep 21, 2015

Reported by fhdk on 21 Sep 2015 16:46 UTC as Trac ticket #1490544

Default installation returns this this error after login.


Warning: Declaration of rcmail::get_instance($env = _) should be compatible with rcube::get_instance($mode = 0, $env = _) in mail/program/include/rcmail.php on line 30

Fix


get_instance($mode = 0, $env = '')

Migrated-From: http://trac.roundcube.net/ticket/1490544

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Comment by @alecpl on 21 Sep 2015 17:08 UTC

What PHP version? I thought our error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED should skip such warnings.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Comment by fhdk on 21 Sep 2015 17:12 UTC

Replying to alec:

What PHP version?

PHP 7.0 - 1.1.3 installer says OK

I thought our error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED should skip such warnings.

I dunno about that

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Comment by @alecpl on 21 Sep 2015 18:42 UTC

We do not plan to support PHP7 in Roundcube < 1.2, you have to use git-master where this is already fixed. There were other fixes for PHP7 support and we find new bugs with every RC release of PHP7.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Status changed by @alecpl on 21 Sep 2015 18:42 UTC

new => closed

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Milestone changed by @alecpl on 21 Sep 2015 18:42 UTC

later => 1.2-beta

@rcubetrac rcubetrac closed this Sep 21, 2015

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Comment by @alecpl on 21 Sep 2015 19:00 UTC

Installer will display "NOT OK" on PHP7 since 0596f79.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Milestone changed by @alecpl on 21 Sep 2015 19:00 UTC

1.2-beta => 1.1.4

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 21, 2015

Summary changed by @alecpl on 21 Sep 2015 19:00 UTC

Declaration of rcmail::get_instance($env = '')

Make installer aware we do not support PHP7 (yet)

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Sep 22, 2015

Comment by fhdk on 22 Sep 2015 11:16 UTC

Changed back to PHP 5.6 and problem solved.

Thanks

@rcubetrac rcubetrac added this to the 1.1.4 milestone Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.