Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery missing on master branch? #5592

Closed
binarykitchen opened this issue Jan 11, 2017 · 7 comments
Closed

jQuery missing on master branch? #5592

binarykitchen opened this issue Jan 11, 2017 · 7 comments

Comments

@binarykitchen
Copy link

@binarykitchen binarykitchen commented Jan 11, 2017

Just pulled from master and seeing a 404 in the browser when loading https://mysite.com/program/js/jquery.min.js

@alecpl

This comment has been minimized.

Copy link
Member

@alecpl alecpl commented Jan 11, 2017

We removed js dependencies from the repo. Now you have to run bin/install-jsdeps.sh script.

@alecpl alecpl closed this Jan 11, 2017
@binarykitchen

This comment has been minimized.

Copy link
Author

@binarykitchen binarykitchen commented Jan 11, 2017

ah, each time after a git pull?

@alecpl

This comment has been minimized.

Copy link
Member

@alecpl alecpl commented Jan 11, 2017

No, but if we bump up dependencies versions you'll have to do this. Note that executing this script for the second time will be fast as it caches the downloaded files.

@binarykitchen

This comment has been minimized.

Copy link
Author

@binarykitchen binarykitchen commented Jan 11, 2017

i see, sweet as - are there any other scripts i should run after a git pull, in general?

@alecpl

This comment has been minimized.

Copy link
Member

@alecpl alecpl commented Jan 11, 2017

Probably composer update and bin/update.sh. All of them are needed only when some dependency or database structure changes.

@binarykitchen

This comment has been minimized.

Copy link
Author

@binarykitchen binarykitchen commented Jan 11, 2017

ok - i think a single entrance to update everything would be good. then the above issue wouldn't have been asked ...

@evs-xsarus

This comment has been minimized.

Copy link

@evs-xsarus evs-xsarus commented Apr 10, 2019

@alecpl it might be an option to install jQuery using composer: https://stackoverflow.com/a/16974088/1025437

PS You could also execute several scripts when composer is finished: https://getcomposer.org/doc/articles/scripts.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.