Wrong tooltip for message browse buttons #757

Closed
rcubetrac opened this Issue Aug 4, 2006 · 8 comments

2 participants

@rcubetrac

Reported by mtu on 4 Aug 2006 13:49 UTC as Trac ticket #1483930

When hovering over the two little arrows in the bottom right corner of the message display, the tooltip for them says "Show next/previous set of messages" instead of "Show next/previous message".

Keywords: tooltip
Migrated-From: http://trac.roundcube.net/ticket/1483930

@rcubetrac

Comment by mtu on 6 Aug 2006 15:39 UTC

patch submitted, waiting for commit

@rcubetrac

Comment by mtu on 8 Aug 2006 16:19 UTC

This fixes the wrong tooltip by referencing a new one called '{next,previous}message' instead of '{next,previous}messages':


diff -uNr rc-294/skins/default/templates/message.html rc-294fix/skins/default/templates/message.html
--- rc-294/skins/default/templates/message.html 2006-08-06 15:51:29.000000000 +0200
+++ rc-294fix/skins/default/templates/message.html      2006-08-06 17:26:15.000000000 +0200
@@ -11,9 +11,9 @@
 <roundcube:include file="/includes/header.html" />

 <div id="messagecountbar">
-<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />
+<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessage" />
 &nbsp;<roundcube:object name="messageCountDisplay" />&nbsp;
-<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" />
+<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessage" />
 </div>

 <div id="messagetoolbar">

This is the standard translation (en_US) for this new label:


diff -uNr rc-294/program/localization/en_US/labels.inc rc-294fix/program/localization/en_US/labels.inc
--- rc-294/program/localization/en_US/labels.inc        2006-08-06 17:09:45.000000000 +0200
+++ rc-294fix/program/localization/en_US/labels.inc     2006-08-06 16:58:43.000000000 +0200
@@ -98,7 +98,9 @@
 $labels[   = 'Move message to trash';
 $labels['printmessage']('deletemessage'])     = 'Print this message';
 $labels[= 'Show previous set of messages';
+$labels['previousmessage']('previousmessages'])  = 'Show previous message';
 $labels[    = 'Show next set of messages';
+$labels['nextmessage']('nextmessages'])      = 'Show next message';
 $labels[      = 'Back to message list';
 $labels['viewsource']('backtolist'])       = 'Show source';

And here are some more translations:


diff -uNr rc-294/program/localization/en_GB/labels.inc rc-294fix/program/localiz                                                                                   ation/en_GB/labels.inc
--- rc-294/program/localization/en_GB/labels.inc        2006-08-06 15:51:20.0000                                                                                   00000 +0200
+++ rc-294fix/program/localization/en_GB/labels.inc     2006-08-06 16:56:16.0000                                                                                   00000 +0200
@@ -99,7 +99,9 @@
 $labels[   = 'Move message to trash';
 $labels['printmessage']('deletemessage'])     = 'Print this message';
 $labels[= 'Show previous set of messages';
+$labels['previousmessage']('previousmessages'])  = 'Show previous message';
 $labels[    = 'Show next set of messages';
+$labels['nextmessage']('nextmessages'])      = 'Show next message';
 $labels[      = 'Back to message list';
 $labels['viewsource']('backtolist'])       = 'Show source';

diff -uNr rc-294/program/localization/de_CH/labels.inc rc-294fix/program/localization/de_CH/labels.inc
--- rc-294/program/localization/de_CH/labels.inc        2006-08-06 15:51:22.000000000 +0200
+++ rc-294fix/program/localization/de_CH/labels.inc     2006-08-06 17:15:07.000000000 +0200
@@ -99,7 +99,9 @@
 $labels[   = 'In den Papierkorb verschieben';
 $labels['printmessage']('deletemessage'])     = 'Diese Nachricht drucken';
 $labels[= 'Vorherige Nachrichten anzeigen';
-$labels['nextmessages']('previousmessages'])     = 'Weitere Nachrichten anzeigen';
+$labels[ = 'Vorherige Nachricht anzeigen';
+$labels['nextmessages']('previousmessage'])     = 'Folgende Nachrichten anzeigen';
+$labels[     = 'Folgende Nachricht anzeigen';
 $labels['backtolist']('nextmessage'])       = 'Zurck zur Liste';

 $labels[= 'Auswhlen';
diff -uNr rc-294/program/localization/de_DE/labels.inc rc-294fix/program/localization/de_DE/labels.inc
--- rc-294/program/localization/de_DE/labels.inc        2006-08-06 15:51:20.000000000 +0200
+++ rc-294fix/program/localization/de_DE/labels.inc     2006-08-06 17:03:49.000000000 +0200
@@ -100,7 +100,9 @@
 $labels['deletemessage']('select'])    = 'In den Papierkorb verschieben';
 $labels[    = 'Diese Nachricht drucken';
 $labels['previousmessages']('printmessage']) = 'Vorherige Nachrichten anzeigen';
-$labels[    = 'Weitere Nachrichten anzeigen';
+$labels['previousmessage']('nextmessages']) =  'Vorherige Nachricht anzeigen';
+$labels[    = 'Folgende Nachrichten anzeigen';
+$labels['nextmessage']('nextmessages'])     =  'Folgende Nachricht anzeigen';
 $labels[      = 'Zurck zur Liste';

 $labels['select']('backtolist']) = 'Auswhlen';

diff -uNr rc-294/program/localization/es/labels.inc rc-294fix/program/localization/es/labels.inc
--- rc-294/program/localization/es/labels.inc   2006-08-06 15:51:22.000000000 +0200
+++ rc-294fix/program/localization/es/labels.inc        2006-08-06 17:05:28.000000000 +0200
@@ -103,7 +103,9 @@
 $labels[   = 'Mover mensaje a la papelera';
 $labels['printmessage']('deletemessage'])     = 'Imprimir este mensaje';
 $labels[= 'Mostrar mensajes anteriores';
+$labels['previousmessage']('previousmessages'])  = 'Mostrar mensaje anterior';
 $labels[    = 'Mostrar mensajes siguientes';
+$labels['nextmessage']('nextmessages'])      = 'Mostrar mensaje siguiente';
 $labels[      = 'Volver a la lista de mensajes';

 $labels['viewsource']('backtolist'])       = 'Mostrar cdigo';

@rcubetrac

Status changed by mtu on 8 Aug 2006 16:19 UTC

new => assigned

@rcubetrac

Owner changed by mtu on 8 Aug 2006 16:19 UTC

=> mtu

@rcubetrac

Owner changed by @thomascube on 8 Sep 2006 09:29 UTC

mtu => thomasb

@rcubetrac

Status changed by @thomascube on 8 Sep 2006 09:29 UTC

assigned => new

@rcubetrac

Comment by @thomascube on 4 Dec 2006 22:35 UTC

Commited with 421f5e3

@rcubetrac

Status changed by @thomascube on 4 Dec 2006 22:35 UTC

new => closed

@rcubetrac rcubetrac closed this Dec 4, 2006
@rcubetrac rcubetrac added this to the 0.1-rc1 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment