Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Adding button to cancel add group action. #15

Closed
wants to merge 10 commits into from

3 participants

@jmatth

When adding a contact group in the addressbook, it's not immediately obvious that hitting escape while focused on the box will remove it. This adds a cancel button to the left of the box in both the Classic and Larry themes.

@jmatth jmatth commented on the diff
skins/larry/ui.js
@@ -152,7 +152,7 @@ function rcube_mail_ui()
if (rcmail.env.action == '') {
new rcube_splitter({ id:'addressviewsplitterd', p1:'#addressview-left', p2:'#addressview-right',
- orientation:'v', relative:true, start:226, min:150, size:12, render:resize_leftcol }).init();
+ orientation:'v', relative:true, start:226, min:225, size:12, render:resize_leftcol }).init();
@jmatth
jmatth added a note

Without this the add group box and cancel button get squashed together when the div gets too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@alecpl
Owner

Button for cancel is not bad, but maybe it would be better to just handle onclick event on the whole UI, so clicking anywhere out of the input will remove the input.

@jmatth jmatth closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 31, 2012
  1. @jmatth
Commits on Aug 6, 2012
  1. @katiepru
Commits on Aug 16, 2012
  1. @katiepru
Commits on Sep 13, 2012
  1. @katiepru

    pull from upstream

    katiepru authored
Commits on Nov 29, 2012
  1. @jmatth
Commits on Jan 2, 2013
  1. @jmatth
Commits on Jan 14, 2013
  1. @jmatth
Commits on Jan 16, 2013
  1. @jmatth
Commits on Feb 11, 2013
  1. @jmatth

    Merge branch 'master' of git://github.com/roundcube/roundcubemail

    jmatth authored
    Conflicts:
    	skins/classic/addressbook.css
    	skins/larry/addressbook.css
Commits on Feb 18, 2013
  1. @jmatth
This page is out of date. Refresh to see the latest.
View
5 program/js/app.js
@@ -4434,9 +4434,10 @@ function rcube_webmail()
return;
if (!this.name_input) {
- this.name_input = $('<input>').attr('type', 'text').data('tt', type);
+ this.name_input = $('<input>').attr('type', 'text').attr('style', 'margin-left:5px;').data('tt', type);
+ this.cancel_button = $('<a>').attr('class', 'canceladd').attr('onclick', 'rcmail.reset_add_input()').attr('href', '#');
this.name_input.bind('keydown', function(e){ return rcmail.add_input_keydown(e); });
- this.name_input_li = $('<li>').addClass(type).append(this.name_input);
+ this.name_input_li = $('<li>').addClass(type).append(this.cancel_button,this.name_input);
var li = type == 'contactsearch' ? $('li:last', this.gui_objects.folderlist) : $('ul.groups li:last', this.get_folder_li(this.env.source,'',true));
if (li.length)
View
10 skins/classic/addressbook.css
@@ -179,6 +179,16 @@
background: url(images/icons/folders.png) 5px -108px no-repeat;
}
+#directorylist li a.canceladd {
+ background: url(images/icons/reset.gif) no-repeat;
+ display: inline;
+ margin-right: -13px;
+ margin-left: -12px;
+ padding-top: 0px;
+ cursor: auto;
+}
+
+#directorylist li.contactgroup,
#directorylist li ul li a
{
padding-left: 45px;
View
9 skins/larry/addressbook.css
@@ -337,6 +337,15 @@ a.deletebutton {
background: url(images/buttons.png) -7px -377px no-repeat;
}
+#directorylist li a.canceladd {
+ background: url(images/buttons.png) -1000px 0 no-repeat;
+ background-position: -26px -317px;
+ display: inline;
+ padding: 4px 24px 5px 0px;
+ cursor: auto;
+ margin-left:5px;
+}
+
#import-box {
position: absolute;
bottom: 28px;
View
2  skins/larry/ui.js
@@ -178,7 +178,7 @@ function rcube_mail_ui()
if (rcmail.env.action == '') {
new rcube_splitter({ id:'addressviewsplitterd', p1:'#addressview-left', p2:'#addressview-right',
- orientation:'v', relative:true, start:226, min:150, size:12, render:resize_leftcol }).init();
+ orientation:'v', relative:true, start:226, min:225, size:12, render:resize_leftcol }).init();
@jmatth
jmatth added a note

Without this the add group box and cancel button get squashed together when the div gets too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
new rcube_splitter({ id:'addressviewsplitter', p1:'#addresslist', p2:'#contacts-box',
orientation:'v', relative:true, start:286, min:270, size:12 }).init();
Something went wrong with that request. Please try again.