export only selected contacts from addressbook #36

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@JohnDoh
Contributor
JohnDoh commented Oct 7, 2012

extend the addressbook export function to pass the contact id(s) of selected contact(s) to be passed to the export script so only those contact(s) are exported.

@thomascube
Member

Thanks for this pull request. In general the feature is very welcome but I assume it can be confusing to the users because the chance is high that one already selected a contact but actually intends to export all. I therefore suggest to extend the patch by adding an options menu to the export button showing two options: "Export all contacts" and "Export selected contacts"

@JohnDoh
Contributor
JohnDoh commented Oct 17, 2012

that's a sensible idea, i have added it. i think the spacing for the dropdown icon in the classic skin is a little off but i cant work out why.

@thomascube
Member

Almost there :-) To ensure backwards compatibility with other skins, the 'export' command should remain. You now changed it to 'export-all'.

@alecpl
Member
alecpl commented Oct 20, 2012

The diff would be much simpler if you keep the old action name (export) instead providing a new one (export-all).

@JohnDoh
Contributor
JohnDoh commented Oct 21, 2012

Much simpler? its adding 1 line and modifying 3 others in one file, app.js. My original request did use the original export action and Thomas requested I split them apart. I tied to stick to Roundcube naming conventions. I think an action called "export" is not clearly named when there are 2 separate functions, one which exports all and one with exports selected.

@alecpl
Member
alecpl commented Oct 21, 2012

Thomas requested change visible to the user, but internally there can/should be only export and export-selected, no need for export-all. This way patch will be shorter.

@thomascube
Member

... and even mor important, the code remains compatible with older skins which still use the 'export' command.

@JohnDoh
Contributor
JohnDoh commented Oct 24, 2012

i'll close this then and try again.

@JohnDoh JohnDoh closed this Oct 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment