extend the addressbook export function to pass the contact id(s) of selected contact(s) to be passed to the export script so only those contact(s) are exported.
export only selected contacts from addressbook
Thanks for this pull request. In general the feature is very welcome but I assume it can be confusing to the users because the chance is high that one already selected a contact but actually intends to export all. I therefore suggest to extend the patch by adding an options menu to the export button showing two options: "Export all contacts" and "Export selected contacts"
seperate export all/selected options in menu
that's a sensible idea, i have added it. i think the spacing for the dropdown icon in the classic skin is a little off but i cant work out why.
Almost there :-) To ensure backwards compatibility with other skins, the 'export' command should remain. You now changed it to 'export-all'.
restore depreciated export command for backwards compatibility
The diff would be much simpler if you keep the old action name (export) instead providing a new one (export-all).
Much simpler? its adding 1 line and modifying 3 others in one file, app.js. My original request did use the original export action and Thomas requested I split them apart. I tied to stick to Roundcube naming conventions. I think an action called "export" is not clearly named when there are 2 separate functions, one which exports all and one with exports selected.
Thomas requested change visible to the user, but internally there can/should be only export and export-selected, no need for export-all. This way patch will be shorter.
... and even mor important, the code remains compatible with older skins which still use the 'export' command.
i'll close this then and try again.