Upgrade package & add demo app#3
Merged
Merged
Conversation
Owner
|
@elwayman02 thanks for the pull request 👍 I'll have a look through it this evening. |
rounders
added a commit
that referenced
this pull request
Sep 23, 2015
Upgrade package & add demo app
Owner
|
merged, looks great @elwayman02, thank you!! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
ember initAn example of the deployed demo can be found here: http://github.jhawk.co/ember-world-flags/
You can deploy it for your own repo using the EmberUp tutorial (skipping the first command, since I've already installed the addon to the project).
Note: The gh-pages build produced by ember-cli-github-pages has a bug with public asset locations. To fix that, simply edit the vendor CSS files as follows:
/ember-world-flags/images/flags16-[fingerprint].pngbecomes
/ember-world-flags/ember-world-flags/images/flags16-[fingerprint].pngand the same for the
flags32file. This will give gh-pages the correct path to find the files when they are deployed.More info on that bug can be found here: poetic/ember-cli-github-pages#11