Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package & add demo app #3

Merged
merged 3 commits into from Sep 23, 2015
Merged

Upgrade package & add demo app #3

merged 3 commits into from Sep 23, 2015

Conversation

@elwayman02
Copy link
Contributor

@elwayman02 elwayman02 commented Sep 22, 2015

This PR does the following:

  1. updates the addon to the latest dependencies via ember init
  2. Adds a demo app and deploys it via ember-cli-github-pages

An example of the deployed demo can be found here: http://github.jhawk.co/ember-world-flags/

You can deploy it for your own repo using the EmberUp tutorial (skipping the first command, since I've already installed the addon to the project).

Note: The gh-pages build produced by ember-cli-github-pages has a bug with public asset locations. To fix that, simply edit the vendor CSS files as follows:

/ember-world-flags/images/flags16-[fingerprint].png
becomes
/ember-world-flags/ember-world-flags/images/flags16-[fingerprint].png

and the same for the flags32 file. This will give gh-pages the correct path to find the files when they are deployed.

More info on that bug can be found here: poetic/ember-cli-github-pages#11

@rounders
Copy link
Owner

@rounders rounders commented Sep 22, 2015

@elwayman02 thanks for the pull request 👍 I'll have a look through it this evening.

rounders added a commit that referenced this pull request Sep 23, 2015
@rounders rounders merged commit 949f7fb into rounders:master Sep 23, 2015
@rounders
Copy link
Owner

@rounders rounders commented Sep 23, 2015

merged, looks great @elwayman02, thank you!!

@elwayman02 elwayman02 deleted the elwayman02:package-upgrade branch Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants