Skip to content

Upgrade package & add demo app#3

Merged
rounders merged 3 commits into
rounders:masterfrom
elwayman02:package-upgrade
Sep 23, 2015
Merged

Upgrade package & add demo app#3
rounders merged 3 commits into
rounders:masterfrom
elwayman02:package-upgrade

Conversation

@elwayman02

Copy link
Copy Markdown
Contributor

This PR does the following:

  1. updates the addon to the latest dependencies via ember init
  2. Adds a demo app and deploys it via ember-cli-github-pages

An example of the deployed demo can be found here: http://github.jhawk.co/ember-world-flags/

You can deploy it for your own repo using the EmberUp tutorial (skipping the first command, since I've already installed the addon to the project).

Note: The gh-pages build produced by ember-cli-github-pages has a bug with public asset locations. To fix that, simply edit the vendor CSS files as follows:

/ember-world-flags/images/flags16-[fingerprint].png
becomes
/ember-world-flags/ember-world-flags/images/flags16-[fingerprint].png

and the same for the flags32 file. This will give gh-pages the correct path to find the files when they are deployed.

More info on that bug can be found here: poetic/ember-cli-github-pages#11

@rounders

Copy link
Copy Markdown
Owner

@elwayman02 thanks for the pull request 👍 I'll have a look through it this evening.

rounders added a commit that referenced this pull request Sep 23, 2015
@rounders rounders merged commit 949f7fb into rounders:master Sep 23, 2015
@rounders

Copy link
Copy Markdown
Owner

merged, looks great @elwayman02, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants