Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Rename xxxLatLon method to xxxCoordinate #76

Open
amjaliks opened this Issue · 1 comment

1 participant

@amjaliks

Rename xxxLatLon method to xxxCoordinate to keep route-me conformance with CoreLocation framework.

Update:
I offer to extend this question to discussion about naming convention for different points. I know there are some guidelines in wiki about this, but they are unclear for me.

My suggestions:

  • coordinate - unprojected coordinates of a point in lat/lon degrees; this name chosen, because the same name is used by Apple in CoreLocation;
  • projectedPoint - projected coordinates of a point in projection units; this name chosen, because of the name of type (RMProjectPoint);
  • screenPoint - coordinates of a point on the screen.

Thus related methods will be called: xxxCoordinate, xxxProjectedPoint, xxxScreenPoint.

@amjaliks

Methods pointToLatLong: and latLongToPoint: of RMProjection are noted to be renamed. Any suggestion for new names?

My suggestion: projectedPointToCoordinate and coordinateToProjectedPoint.

@whiteboxcode whiteboxcode referenced this issue from a commit in whiteboxcode/mapbox-ios-sdk
@incanus incanus refs #76: send a dupe heading update after device rotation 54d32f9
@whiteboxcode whiteboxcode referenced this issue from a commit in whiteboxcode/mapbox-ios-sdk
@incanus incanus refs #76: improvements to tracking centering/zooming updates 4919622
@whiteboxcode whiteboxcode referenced this issue from a commit in whiteboxcode/mapbox-ios-sdk
@incanus incanus refs #76: use proper API for device/compass rotation 40acbb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.