RMPath rewrite #165

Merged
merged 2 commits into from Mar 8, 2012

Conversation

Projects
None yet
5 participants
Owner

michaeltyson commented Feb 21, 2012

This is the RMPath rewrite I did last year for my app - it's still in use, and works better for me than the implementation currently in the main branch.

  • Much more efficient; rendered in the background on a CALayer within view bounds - dramatically faster for long paths
  • Cleaner implementation with revised geometry
  • Direct access to path, for hit testing, etc
  • Projected bounds accessor

michaeltyson added some commits Feb 21, 2012

@michaeltyson michaeltyson New RMPath implementation
- Cleaner implementation with revised geometry
- Direct access to path, for hit testing, etc
- Projected bounds accessor
- Fixed RMMapContents bug resulting in overlay corruption while zooming
2235ace
@michaeltyson michaeltyson RMPath performance enhancement: Only render path after drag/zoom moti…
…on ended
37862c5
Contributor

tracyharton commented Mar 6, 2012

Works better for me, as well, and I haven't encountered any issues...

Owner

michaeltyson commented Mar 6, 2012

Thanks Tracy! (and thanks for all your work!)

rpcarver commented Mar 8, 2012

Works wonderfully for me! Solved a couple of issues I was waiting till I had some more round tuits to dig in and fix. Thanks!

Owner

michaeltyson commented Mar 8, 2012

Great - well, I'm going to take this as sufficient endorsement and merge this bad boy. Here goes!

@michaeltyson michaeltyson added a commit that referenced this pull request Mar 8, 2012

@michaeltyson michaeltyson Merge pull request #165 from michaeltyson/path-rewrite
RMPath rewrite
662ad78

@michaeltyson michaeltyson merged commit 662ad78 into route-me:master Mar 8, 2012

Contributor

incanus commented Mar 20, 2012

This commit got rid of path shadows, line cap & line join, drawing mode...

Contributor

tracyharton commented Mar 21, 2012

Well, that's a pisser

Owner

michaeltyson commented Mar 21, 2012

Pretty easy to add back though. I'll take a look soon.

Owner

michaeltyson commented Mar 21, 2012

See Pull #169.

Does anyone else experience memory spikes and crashes occasionally, when zooming in quickly on a mapView with paths showing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment