New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subject history collide #49

Merged
merged 1 commit into from May 30, 2012

Conversation

Projects
None yet
2 participants
@mczepiel

mczepiel commented May 30, 2012

If the column for presenting refs is not wide enough to actually draw
any refs, the rectangle we started with that accounted for the history
lines already should not be adjusted with the rect(0,0,0,0).

In useful sized columns that zero rect would be updated as refs that can
be drawn are drawn ensuring the subject appears to the right.

This addresses gh-48

Preserve rectangle for drawing subject if refs too long
If the column for presenting refs is not wide enough to actually draw
any refs, the rectangle we started with that accounted for the history
lines already should not be adjusted with the rect(0,0,0,0).

In useful sized columns that zero rect would be updated as refs that can
be drawn are drawn ensuring the subject appears to the right.
@rowanj

This comment has been minimized.

Owner

rowanj commented May 30, 2012

The visible effect of this issue is that the text would overlay the graphical commit links that are drawn in the subject column of the history view; if the subject column was sufficiently narrow.

before: http://i45.tinypic.com/2chp72e.jpg
after: http://i45.tinypic.com/2gxp4e1.jpg

@rowanj rowanj merged commit 1f6af26 into rowanj:master May 30, 2012

ssp pushed a commit to ssp/gitx that referenced this pull request Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment