Make SHA text fields fixed width font #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when resizing a SHA column you never end up with some parts of the SHA being clipped as you do with proportional spaced fonts. SHA columns also have reasonable min/max widths given the expected widths of their content. I also moved the short SHA column to the front and made it visible by default as that seems handy but that might be pushy.
|
Not 100% sold on the font choice - it seems significantly heavier than the neighbouring text, but definitely a huge improvement. Thanks again! |
ssp
added a commit
to ssp/gitx
that referenced
this pull request
Feb 26, 2017
This seems to fix the remaining problem mentioned in rowanj#52
ssp
added a commit
to ssp/gitx
that referenced
this pull request
Feb 26, 2017
This seems to fix the remaining problem mentioned in rowanj#52
ssp
added a commit
to ssp/gitx
that referenced
this pull request
Feb 28, 2017
This seems to fix the remaining problem mentioned in rowanj#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now when resizing a SHA column you never end up with some parts of
the SHA being clipped as you do with proportional spaced fonts.
SHA columns also have reasonable min/max widths given the expected
widths of their content.
I also moved the short SHA column to the front and made it visible by
default as that seems handy but that might be pushy.
Before: http://tinypic.com/r/15e6yyo/6
Notice clipping of letters in some rows as proportional characters don't line up
After: http://tinypic.com/r/1t5sua/6
Again this is a small nit, but I think this looks nicer as the characters all line up nicely