New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SHA text fields fixed width font #52

Merged
merged 1 commit into from May 31, 2012

Conversation

Projects
None yet
2 participants
@mczepiel

mczepiel commented May 31, 2012

Now when resizing a SHA column you never end up with some parts of
the SHA being clipped as you do with proportional spaced fonts.

SHA columns also have reasonable min/max widths given the expected
widths of their content.

I also moved the short SHA column to the front and made it visible by
default as that seems handy but that might be pushy.

Before: http://tinypic.com/r/15e6yyo/6
Notice clipping of letters in some rows as proportional characters don't line up

After: http://tinypic.com/r/1t5sua/6
Again this is a small nit, but I think this looks nicer as the characters all line up nicely

Make SHA text fields fixed width font
Now when resizing a SHA column you never end up with some parts of
the SHA being clipped as you do with proportional spaced fonts.

SHA columns also have reasonable min/max widths given the expected
widths of their content.

I also moved the short SHA column to the front and made it visible by
default as that seems handy but that might be pushy.

rowanj added a commit that referenced this pull request May 31, 2012

@rowanj rowanj merged commit 40cb161 into rowanj:master May 31, 2012

@rowanj

This comment has been minimized.

Owner

rowanj commented May 31, 2012

Not 100% sold on the font choice - it seems significantly heavier than the neighbouring text, but definitely a huge improvement. Thanks again!

samsonjs pushed a commit to samsonjs/gitx that referenced this pull request Jul 15, 2016

ssp added a commit to ssp/gitx that referenced this pull request Feb 26, 2017

update to current objective-git
This seems to fix the remaining problem mentioned in rowanj#52

ssp added a commit to ssp/gitx that referenced this pull request Feb 26, 2017

update to current objective-git
This seems to fix the remaining problem mentioned in rowanj#52

ssp added a commit to ssp/gitx that referenced this pull request Feb 28, 2017

update to current objective-git
This seems to fix the remaining problem mentioned in rowanj#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment