Commits on Feb 18, 2015
Commits on Feb 17, 2015
  1. Auto merge of #21774 - ejjeong:enable-test-for-android, r=alexcrichton

    - Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works (#21773)
    - Fix & enable debuginfo tests for android (#10381)
    - Fix & enable more tests for android (both for arm/aarch64)
    - Enable many already-pass tests on android (both for arm/aarch64)
    bors committed Feb 17, 2015
  2. Auto merge of #22311 - lfairy:consistent-fmt, r=alexcrichton

    This brings it in line with its namesake in `std::io`.
    r? @aturon
    bors committed Feb 17, 2015
  3. Auto merge of #22397 - Manishearth:rollup, r=huonw

    bors committed Feb 17, 2015
  4. Auto merge of #21932 - Jormundir:std-os-errno-type, r=alexcrichton

    Changes std::os::errno to return i32, the return type used by the function being delegated to.
    This is my first contribution, so feel free to give me advice. I'll be happy to correct things.
    bors committed Feb 17, 2015
  5. Rollup merge of #22409 - nikomatsakis:stop-advertisting-old-impl-chec…

    …k, r=aturon
     Stop advertisting the `old_impl_check` feature. We can't ENTIRELY remove it yet, but we don't have to add new uses.
    r? @aturon
    Manishearth committed Feb 17, 2015
  6. Rollup merge of #22420 - posixphreak:fix-rustup-locale, r=brson

     Since `tr` converts lowercase to uppercase according to system locale using `LC_CTYPE` environment variable; on some locales, fails to use correct variables names, thus deletes temporarily downloaded files and gives a meaningless error as shown below. This a simple fix which explictly sets `LC_CTYPE` as `C`.
    Here is what happens without the fix:
    ➜  projects  curl -s | sudo sh
    rustup: CFG_CURL             := /usr/bin/curl (7.22.0)
    rustup: CFG_TAR              := /bin/tar (1.26)
    rustup: CFG_FILE             := /usr/bin/file (5.09)
    rustup: CFG_SHA256SUM        := /usr/bin/sha256sum (256sum)
    rustup: CFG_SHASUM           := /usr/bin/shasum (5.61)
    rustup: processing sh args
    rustup: CFG_PREFiX           :=
    rustup: CFG_DATE             :=
    rustup: validating sh args
    rustup: host triple: i686-unknown-linux-gnu
    rustup: Downloading to /tmp/tmp.Wz6F1ToG5z/rust-nightly-i686-unknown-linux-gnu.tar.gz
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  132M  100  132M    0     0  59947      0  0:38:31  0:38:31 --:--:-- 71204
    rustup: Downloading
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100   109  100   109    0     0    107      0  0:00:01  0:00:01 --:--:--   169
    rustup: Verifying hash
    rustup: Extracting /tmp/tmp.Wz6F1ToG5z/rust-nightly-i686-unknown-linux-gnu.tar.gz
    install: looking for install programs
    install: found mkdir
    install: found printf
    install: found cut
    install: found grep
    install: found uname
    install: found tr
    install: found sed
    install: found chmod
    install: processing /tmp/tmp.Wz6F1ToG5z/rust-nightly-i686-unknown-linux-gnu/ args
    install: CFG_DESTDiR          :=
    install: CFG_PREFiX           := /usr/local
    install: CFG_LiBDiR           := /lib
    install: CFG_MANDiR           := /share/man
    install: validating /tmp/tmp.Wz6F1ToG5z/rust-nightly-i686-unknown-linux-gnu/ args
    install: verifying platform can run binaries
    install: verifying destination is writable
    mkdir: cannot create directory `': No such file or directory
    install: error: can't write to destination. consider `sudo`.
    rustup: error: failed to install Rust
    Notice how `i` wasn't replaced with `I`.
    Rust is installed as usual after the fix. Tested on Ubuntu x86 12.04 LTS.
    I'm not exactly sure if setting LC_CTYPE is the best solution, but there's that.
    Manishearth committed Feb 17, 2015
  7. Rollup merge of #22411 - aturon:fix-os-deprecation, r=alexcrichton

     They now point to the correct locations in std::env
    r? @alexcrichton
    Manishearth committed Feb 17, 2015
  8. Rollup merge of #22394 - alexcrichton:vec-from-iter-comment, r=brson

     Requested by Niko in #22200 (and is good to have anyway)
    Manishearth committed Feb 16, 2015
  9. std: Add Vec::from_iter comment

    Requested by Niko in #22200 (and is good to have anyway)
    alexcrichton committed with Manishearth Feb 16, 2015
  10. Rollup merge of #22225 - vhbit:darwin-types, r=alexcrichton

       "body": null,
    Manishearth committed Feb 16, 2015
  11. Rollup merge of #22273 - nagisa:doc-deprecated, r=alexcrichton

     Since we don’t have Deprecated stability level anymore, the only other source of information is
    deprecated-since version, which conveniently to us, only exists if the symbol is deprecated.
    Fixes #21789
    Manishearth committed Feb 16, 2015
  12. Rollup merge of #22313 - japaric:iter, r=aturon

     `IntoIterator` now has an extra associated item:
    ``` rust
    trait IntoIterator {
        type Item;
        type IntoIter: Iterator<Self=Self::Item>;
    This lets you bind the iterator \"`Item`\" directly when writing generic functions:
    ``` rust
    // hypothetical change, not included in this PR
    impl Extend<T> for Vec<T> {
        // you can now write
        fn extend<I>(&mut self, it: I) where I: IntoIterator<Item=T> { .. }
        // instead of
        fn extend<I: IntoIterator>(&mut self, it: I) where I::IntoIter: Iterator<Item=T> { .. }
    The downside is that now you have to write an extra associated type in your `IntoIterator` implementations:
    ``` diff
     impl<T> IntoIterator for Vec<T> {
    +    type Item = T;
         type IntoIter = IntoIter<T>;
         fn into_iter(self) -> IntoIter<T> { .. }
    Because this breaks all downstream implementations of `IntoIterator`, this is a [breaking-change]
    r? @aturon
    Manishearth committed Feb 16, 2015
  13. Rollup merge of #22326 - semarie:compat-cp, r=alexcrichton

     `cp -a` is a GNU extension. Use an alternate combinaison of POSIX options
    (`-PRp`) that do nearly the same.
    The difference is `-a` will preserve context, links and xattr attributes,
    whereas `-p` not. But as we use it only for copy a file, there is no
    difference in the current context.
    Manishearth committed Feb 16, 2015
  14. Rollup merge of #22344 - nagisa:exactsizediter, r=alexcrichton

     Appears to be just an oversight given it is the only method in a stable trait.
    r? @aturon because you did final alpha stabilisation of iterators.
    Manishearth committed Feb 16, 2015
  15. Rollup merge of #22392 - laijs:fix-reference-md-plugin-link, r=stevek…

    book/syntax-extensions.html was renamed to book/plugins.html,
    the link should be also updated.
    Signed-off-by: Lai Jiangshan <>
    Manishearth committed Feb 16, 2015
  16. Rollup merge of #22378 - jxcl:master, r=steveklabnik

    The Rust Programming Language book has no explanation of what `i32` actually means. I have added an explanation for the first time the reader encounters this type.
    Manishearth committed Feb 16, 2015
  17. Rollup merge of #22377 - thiagooak:book-glossary, r=steveklabnik

    @steveklabnik Trying out the Glossary idea.
    Added the paragraph about 'complicated words' because I think it would be useful to those contributing to the book. Maybe this should not be here
    Manishearth committed Feb 16, 2015
  18. Rollup merge of #22374 - richo:warn-fixup, r=huonw

    This snuck through my refactor.
    Would it be worth the effort to have a test pass that attempts to lint the code for all targets, even if it's not feasible to actually build and test it?
    Manishearth committed Feb 16, 2015
  19. Rollup merge of #22366 - dotdash:ret_adjust, r=alexcrichton

    Without the adjustments the retslot might have the wrong type, e.g. when
    the return value is implicitly coerced to a trait object.
    Fixes #22346
    Manishearth committed Feb 16, 2015
  20. Rollup merge of #22365 - serejkus:configs-link, r=steveklabnik

    The book in "hello-world" tells that there are configs for some programs and gives a link to main repo's src/etc. Actually, these configs moved to separate repos some days ago. This PR adds a markdown file with links and moves "hello-world" link about editors to point directly to this new file.
    Manishearth committed Feb 16, 2015
  21. Rollup merge of #22363 - semarie:openbsd-test_file_desc, r=alexcrichton

    `pipe(2)`, under FreeBSD and OpenBSD return a bidirectionnal pipe. So
    reading from the writer would block (waiting data) instead of returning
    an error.
    like for FreeBSD, disable the test for OpenBSD.
    Manishearth committed Feb 16, 2015
  22. Rollup merge of #22341 - fhahn:issue-22291-PLEASE-FAIL, r=alexcrichton

    This is a patch for #22291.
    PLEASE_BENCH=1 adds --bench to the arguments passed to the executable to be tested. At the moment, compiletest does not accept a --bench argument, because it is not needed for any test in src/test/, even the tests in src/test/bench do not use #[bench].
    I have updated the makefile to only add the --bench flag for crate tests. I do not think that changing compiletest add --bench to the run arguments of all compile tests makes sense, because it would mess up tests which check command line arguments. Also the bench option can be added as comment in a compile test as well.
    Manishearth committed Feb 16, 2015
  23. Rollup merge of #22253 - huonw:unstable-words, r=aturon

    It is not totally clear if we should just use whitespace, or if the full
    unicode word-breaking algorithm is more correct. If there is demand we
    can reconsider this decision (and consider the precise algorithm to use
    in detail).
    cc #15628.
    Manishearth committed Feb 16, 2015
Commits on Feb 16, 2015
  1. Auto merge of #22230 - nikomatsakis:object-lifetime-defaults-2, r=pnk…

    Implement rules described in rust-lang/rfcs#599.
    Fixes rust-lang#22211.
    ~~Based atop PR rust-lang#22182, so the first few commits (up to and including "Pacify the mercilous nrc") have already been reviewed.~~
    bors committed Feb 16, 2015