builddep: Test for using macro defines with source rpms #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also check if the dnf5 builddep plugin has the same problem? And if it has add the warning there as well? We could then enable this test also for dnf5 with the |
Yes I checked it and it is happening also with dnf5. I will deliver the fix in separate PR and then I will add the dnf5 tag here and I'll switch it back to you. Thanks. |
jan-kolarik
force-pushed
the
jkolarik/builddep-macros-srpm-test
branch
from
8984114
to
04a5017
Compare
|
Is this waiting on something or can we move it from the draft stage and merge it? |
|
@kontura Oh sorry, I just forgot to switch the state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: