New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module element in updateinfo.xml #116
Conversation
|
@kontura could you split the python changes into a new PR? |
|
I'm a little concerned we're just randomly extending the updateinfo.xml format here, especially since createrepo_c cannot validate or create module XML metadata. If we want to merge this, I really want this guarded by a flag, because it technically generates invalid updateinfo.xml per the schema for it. |
|
@Conan-Kudo could you be more specific about the module XML metadata? About the updateinfo.xml schema - do you know who owns it and where it lives? |
|
@dmach I mean that As for the |
|
@Conan-Kudo I think validating links between updateinfo.xml and modulemd is out of scope. Thanks for the schema links. |
|
@dmach Hmm. |
src/updateinfo.h
Outdated
| typedef struct { | ||
| gchar *name; | ||
| gchar *stream; | ||
| gchar *version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kontura, is there a reason for a version to be of gchar type?
In libmodulemd it's guint64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated it to be guint64 as well.
One thing I am not sure about, what should happen when the parsing of the version number fails? Is setting it to 0 ok?
Two features: