Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module element in updateinfo.xml #116

Merged
merged 1 commit into from Apr 29, 2019

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jan 8, 2019

Two features:

  • add CMake support for python interpreter path, so its possible to either specify python version or path to interpreter
  • add support for module element in updateinfo.xml

@kontura kontura changed the title amatej python interpreter path and module element in updateinfo.xml Jan 8, 2019
@dmach
Copy link

dmach commented Jan 30, 2019

@kontura could you split the python changes into a new PR?
I'd probably merge it in soon, but the modularity part will probably stay open for a while...

@kontura kontura changed the title python interpreter path and module element in updateinfo.xml Add module element in updateinfo.xml Jan 31, 2019
@Conan-Kudo
Copy link
Member

I'm a little concerned we're just randomly extending the updateinfo.xml format here, especially since createrepo_c cannot validate or create module XML metadata.

If we want to merge this, I really want this guarded by a flag, because it technically generates invalid updateinfo.xml per the schema for it.

@dmach
Copy link

dmach commented Mar 28, 2019

@Conan-Kudo could you be more specific about the module XML metadata?
What do you mean exactly?
The goal here is to extend updateinfo with module identifiers (N:S:V:C:A)
so we can track relation between streams and RPMs.

About the updateinfo.xml schema - do you know who owns it and where it lives?
We definitely want to stay in sync with the schema.
The updateinfo.xml from F29 doesn't contain any schema link and that makes me think that the format is more a tribal knowledge than a proper standard.

@Conan-Kudo
Copy link
Member

@dmach I mean that createrepo_c can't validate links between the XML data in updateinfo about modules and the modules YAML data to make sure it is valid.

As for the updateinfo.xml schema... I know of two schema definitions that exist. One is in python-Updateinfo, which comes from Scientific Linux. This project attempts to rationalize the variation between Bodhi and OBS's implementations. The other is in libzypp, which I think was used to do the original implementation of the YUM/RPM-MD format for Zypper a decade ago...

@dmach
Copy link

dmach commented Mar 29, 2019

@Conan-Kudo I think validating links between updateinfo.xml and modulemd is out of scope.
This has to be tested outside createrepo_c.
If you think about it, updateinfo RPMs are not validated against primary.xml either.

Thanks for the schema links.

@Conan-Kudo
Copy link
Member

@dmach Hmm.

src/updateinfo.h Outdated
typedef struct {
gchar *name;
gchar *stream;
gchar *version;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kontura, is there a reason for a version to be of gchar type?
In libmodulemd it's guint64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it to be guint64 as well.
One thing I am not sure about, what should happen when the parsing of the version number fails? Is setting it to 0 ok?

@Conan-Kudo Conan-Kudo merged commit 7787b34 into rpm-software-management:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants