Fix memory leaks in python extension code #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no good way to make PyObject_ToStrOrNull() work. It requires allocating an intermediate value, and we can't deallocate it because the return value points into the buffer. Need to just return the PyBytes PyObject so that it's lifetime can be managed by the caller. Additionally, the PyObject_ToChunkedString() function seems under-utilized, we can improve it and use it to keep the ergonomics that we had before.
dralley
force-pushed
the
mem-leak-fixes
branch
from
53719df
to
ff988b9
Compare
|
Thanks, @dralley, for finding the spot and for your fix! Just to give an idea of the level of improvement it brings. |
|
That's amazing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #230 (bz #1893459)
Additionally fixes a couple of other memory leaks. Completely removes the
PyObject_ToStrOrNull()function which cannot possibly work without leaking memory.