Memory leak fixes (in library, not extension code)

[dralley]

No description provided.

[dralley]

Related issues that are not fixed in this PR: #232

(wasn't able to figure them out)

[kontura]

I think this is not the right place to free the hdr_checksum, it should be freed together with the rest of the stat struct, ideally by cr_contentstat_free. Its generally not bound to the cr_file, its managed on its own. In fact when running with zchunk (createrepo_c --zck .) this call is causing a double free.

I have looked around where the hdr_checksum could be leaking and I believe that the problem is here: https://github.com/rpm-software-management/createrepo_c/blob/master/src/repomd.c#L199
It should be using the cr_contentstat_free function.

Otherwise looks good to me. 🙂

[dralley]

fixed!

[dralley]

@kontura (re-do) Fixed now. Thank you!

============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.6.8, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /usr/local/lib/pulp/bin/python
cachedir: .pytest_cache
rootdir: /home/vagrant/devel/community/createrepo_c
collected 3 items                                                                                                                                                                                                                            

tests/python/tests/test_compression_wrapper.py::TestCaseCompressionWrapper::test_compression_suffix PASSED                                                                                                                             [ 33%]
tests/python/tests/test_compression_wrapper.py::TestCaseCompressionWrapper::test_compression_type PASSED                                                                                                                               [ 66%]
tests/python/tests/test_compression_wrapper.py::TestCaseCompressionWrapper::test_detect_compression PASSED                                                                                                                             [100%]

============================================================================================================= 3 passed in 4.34s ==============================================================================================================
==9367== 
==9367== HEAP SUMMARY:
==9367==     in use at exit: 7,707,942 bytes in 61,837 blocks
==9367==   total heap usage: 895,713 allocs, 833,876 frees, 177,775,340 bytes allocated
==9367== 
==9367== LEAK SUMMARY:
==9367==    definitely lost: 0 bytes in 0 blocks
==9367==    indirectly lost: 0 bytes in 0 blocks
==9367==      possibly lost: 2,455,124 bytes in 17,977 blocks
==9367==    still reachable: 5,252,818 bytes in 43,860 blocks
==9367==                       of which reachable via heuristic:
==9367==                         newarray           : 1,536 bytes in 16 blocks
==9367==         suppressed: 0 bytes in 0 blocks
==9367== Reachable blocks (those to which a pointer was found) are not shown.
==9367== To see them, rerun with: --leak-check=full --show-leak-kinds=all