Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system-upgrade] Upgrade groups and environments #183

Closed

Conversation

pkratoch
Copy link
Contributor

Also add switch --no-group-upgrade to disable the group upgrade

= changelog =
msg: [system-upgrade] Upgrade groups and environments; can be switched off with --no-group-upgrade
type: enhancement
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1845562
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1860408
related: https://bugzilla.redhat.com/show_bug.cgi?id=1814306

@lukash
Copy link
Contributor

lukash commented Aug 31, 2020

FWIW it should be possible to add system-upgrade tests to ci-dnf-stack by modifying its data to appear the system has rebooted. I think I'll need to do it eventually when switching to the Transaction Store/Replay format.

@pkratoch
Copy link
Contributor Author

FWIW it should be possible to add system-upgrade tests to ci-dnf-stack by modifying its data to appear the system has rebooted. I think I'll need to do it eventually when switching to the Transaction Store/Replay format.

That would be awesome!

Btw, I also tried how it behaves when the group installation and excluded packages are defined in kickstart (because Anaconda might use dnf differently than dnf CLI) or when some group packages are excluded in one of Fedora spins (because I don't know how these are created), and the system-upgrade seems to work well (the group upgrade part) in both of these cases.

@pkratoch
Copy link
Contributor Author

pkratoch commented Sep 1, 2020

I found the following problem: when an environment is installed and one of its groups is removed, then the whole system upgrade fails. Reported as https://bugzilla.redhat.com/show_bug.cgi?id=1872586 .
I am marking this PR as blocked until the bug is fixed (or worked around by e.g. not upgrading environments during system-upgrade for now).

@pkratoch
Copy link
Contributor Author

The fix for bug 1872586 is merged upstream, so I am removing the 'blocked' label.

@j-mracek
Copy link
Member

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 359e72b has been approved by j-mracek

@rh-atomic-bot
Copy link

⌛ Testing commit 359e72b with merge 7322205...

rh-atomic-bot pushed a commit that referenced this pull request Sep 25, 2020
= changelog =
msg: [system-upgrade] Upgrade groups and environments
type: enhancement
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1845562
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1860408
related: https://bugzilla.redhat.com/show_bug.cgi?id=1814306

Closes: #183
Approved by: j-mracek
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@pkratoch
Copy link
Contributor Author

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 359e72b with merge 222f6f8...

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: j-mracek
Pushing 222f6f8 to master...

@pkratoch pkratoch deleted the group-upgrade branch October 5, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants