New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report excludes for every command just before run (RhBug:1656726) #1289
Report excludes for every command just before run (RhBug:1656726) #1289
Conversation
dnf/cli/cli.py
Outdated
|
||
# Reports about excludes and includes (but not from plugins) | ||
if self.base.conf.excludepkgs: | ||
logger.debug(_('Excludes in dnf.conf: ') + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W504] line break after binary operator
dnf/cli/cli.py
Outdated
logger.debug(_('Excludes in dnf.conf: ') + | ||
", ".join(sorted(set(self.base.conf.excludepkgs)))) | ||
if self.base.conf.includepkgs: | ||
logger.debug(_('Includes in dnf.conf: ') + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W504] line break after binary operator
dnf/cli/cli.py
Outdated
logger.debug(_('Excludes in repo ') + repo.id + ": " + | ||
", ".join(sorted(set(repo.excludepkgs)))) | ||
if repo.includepkgs: | ||
logger.debug(_('Includes in repo ') + repo.id + ": " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W504] line break after binary operator
dnf/cli/cli.py
Outdated
", ".join(sorted(set(self.base.conf.includepkgs)))) | ||
for repo in self.base.repos.iter_enabled(): | ||
if repo.excludepkgs: | ||
logger.debug(_('Excludes in repo ') + repo.id + ": " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W504] line break after binary operator
a62f22f
to
bb67f5c
Compare
+ ", ".join(sorted(set(repo.excludepkgs)))) | ||
if repo.includepkgs: | ||
logger.debug(_('Includes in repo ') + repo.id + ": " | ||
+ ", ".join(sorted(set(repo.includepkgs)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W503] line break before binary operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is correct splitting here
for repo in self.base.repos.iter_enabled(): | ||
if repo.excludepkgs: | ||
logger.debug(_('Excludes in repo ') + repo.id + ": " | ||
+ ", ".join(sorted(set(repo.excludepkgs)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] posted by Sider
[W503] line break before binary operator
@rh-atomic-bot try |
☀️ Test successful - status-papr |
https://bugzilla.redhat.com/show_bug.cgi?id=1656726