Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report excludes for every command just before run (RhBug:1656726) #1289

Merged
merged 1 commit into from Jan 11, 2019

Conversation

j-mracek
Copy link
Member

dnf/cli/cli.py Outdated

# Reports about excludes and includes (but not from plugins)
if self.base.conf.excludepkgs:
logger.debug(_('Excludes in dnf.conf: ') +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W504] line break after binary operator

dnf/cli/cli.py Outdated
logger.debug(_('Excludes in dnf.conf: ') +
", ".join(sorted(set(self.base.conf.excludepkgs))))
if self.base.conf.includepkgs:
logger.debug(_('Includes in dnf.conf: ') +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W504] line break after binary operator

dnf/cli/cli.py Outdated
logger.debug(_('Excludes in repo ') + repo.id + ": " +
", ".join(sorted(set(repo.excludepkgs))))
if repo.includepkgs:
logger.debug(_('Includes in repo ') + repo.id + ": " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W504] line break after binary operator

dnf/cli/cli.py Outdated
", ".join(sorted(set(self.base.conf.includepkgs))))
for repo in self.base.repos.iter_enabled():
if repo.excludepkgs:
logger.debug(_('Excludes in repo ') + repo.id + ": " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W504] line break after binary operator

+ ", ".join(sorted(set(repo.excludepkgs))))
if repo.includepkgs:
logger.debug(_('Includes in repo ') + repo.id + ": "
+ ", ".join(sorted(set(repo.includepkgs))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W503] line break before binary operator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is correct splitting here

for repo in self.base.repos.iter_enabled():
if repo.excludepkgs:
logger.debug(_('Excludes in repo ') + repo.id + ": "
+ ", ".join(sorted(set(repo.excludepkgs))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8] posted by Sider

[W503] line break before binary operator

@j-mracek
Copy link
Member Author

j-mracek commented Jan 2, 2019

@rh-atomic-bot try

@rh-atomic-bot
Copy link

⌛ Trying commit bb67f5c with merge e2e58d1...

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
State: approved= try=True

@m-blaha m-blaha merged commit 6d33bf7 into rpm-software-management:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants