Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base.fill_sack(): add skip_if_unavailable argument (RhBug:1189083) #225

Closed

Conversation

jsilhan
Copy link
Contributor

@jsilhan jsilhan commented Feb 23, 2015

No description provided.

@ghost
Copy link

ghost commented Feb 24, 2015

Why it has to be in fill_sack? =-O It doesn't make a sense to me. Why should we modify repositories when creating a sack? I think this is not correct place for convenient setting of all repositories. If it is needed at all, I think it should be in RepoDict. Otherwise, the number of arguments of fill_sack is going to raise infinitely.

I think that for the bug it would be enough to add skip_if_unavailable to API. I think that we will need to add it there anyway since it is already configurable from dnf.conf.

@timlau
Copy link
Contributor

timlau commented Feb 24, 2015

something like self.repos.all().set_skip_if_unavailable(True) could be a way to set this flag for alle repos. I agree it feels misplaced in fill_sack

@jsilhan
Copy link
Contributor Author

jsilhan commented Mar 13, 2015

Right, Repo.skip_if_unavailable added to API in commit 05b03fc.

@jsilhan jsilhan closed this Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants