New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: skipped conflicts are set (RhBug:1252032) #333

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jsilhan
Contributor

jsilhan commented Aug 10, 2015

No description provided.

@nphilipp

This comment has been minimized.

Show comment
Hide comment
@nphilipp

nphilipp Aug 11, 2015

Contributor

Shouldn't Output._skipped_conflicts() itself rather cast the map iterator to a set before returning it?

Contributor

nphilipp commented Aug 11, 2015

Shouldn't Output._skipped_conflicts() itself rather cast the map iterator to a set before returning it?

@jsilhan

This comment has been minimized.

Show comment
Hide comment
@jsilhan

jsilhan Aug 12, 2015

Contributor

Maybe you're right. Although the set is required only in 1/6 operations (when user updates all packages). I made it consistent with _skipped_broken_deps. This is Python, we prefer maintainability over performance.

Contributor

jsilhan commented Aug 12, 2015

Maybe you're right. Although the set is required only in 1/6 operations (when user updates all packages). I made it consistent with _skipped_broken_deps. This is Python, we prefer maintainability over performance.

@rholy rholy self-assigned this Aug 12, 2015

@jsilhan jsilhan referenced this pull request Aug 12, 2015

Closed

Installonly #334

@rholy

This comment has been minimized.

Show comment
Hide comment
@rholy

rholy Aug 12, 2015

Contributor

So far, I have no idea how to design a package so that it is returned by best_run_diff() if I run dnf upgrade...

Contributor

rholy commented Aug 12, 2015

So far, I have no idea how to design a package so that it is returned by best_run_diff() if I run dnf upgrade...

@rholy

This comment has been minimized.

Show comment
Hide comment
@rholy

rholy Aug 12, 2015

Contributor

Found a hacky way... Merged, thanks.

Contributor

rholy commented Aug 12, 2015

Found a hacky way... Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment