New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option --nogpgcheck (RhBug:1381216) #634

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@@ -959,7 +959,7 @@ def __init__(self, parent, section=None, parser=None):
def _configure_from_options(self, opts):
"""Configure repos from the opts. """
if getattr(opts, 'nogpgcheck', None):
if getattr(opts, 'gpgcheck', None) is False:

This comment has been minimized.

@ignatenkobrain

ignatenkobrain Oct 14, 2016

Member

I think None -> True as well

@ignatenkobrain

ignatenkobrain Oct 14, 2016

Member

I think None -> True as well

This comment has been minimized.

@j-mracek

j-mracek Oct 14, 2016

Contributor

I don't think so.

@j-mracek

j-mracek Oct 14, 2016

Contributor

I don't think so.

This comment has been minimized.

@j-mracek

j-mracek Oct 14, 2016

Contributor

See /home/jmracek/Projects/dnf/dnf/cli/option_parser.py

@j-mracek

j-mracek Oct 14, 2016

Contributor

See /home/jmracek/Projects/dnf/dnf/cli/option_parser.py

@mhatina

This comment has been minimized.

Show comment
Hide comment
@mhatina
Member

mhatina commented Oct 17, 2016

@mluscon

This comment has been minimized.

Show comment
Hide comment
@mluscon

mluscon Oct 18, 2016

Contributor
Contributor

mluscon commented Oct 18, 2016

@dnf-bot

This comment has been minimized.

Show comment
Hide comment
@dnf-bot

dnf-bot Oct 18, 2016

Member

📌 Commit b2fa0a9 has been approved by mluscon

Member

dnf-bot commented Oct 18, 2016

📌 Commit b2fa0a9 has been approved by mluscon

@dnf-bot

This comment has been minimized.

Show comment
Hide comment
@dnf-bot

dnf-bot Oct 18, 2016

Member

⌛️ Testing commit b2fa0a9 with merge 5945ec5...

Member

dnf-bot commented Oct 18, 2016

⌛️ Testing commit b2fa0a9 with merge 5945ec5...

@dnf-bot

This comment has been minimized.

Show comment
Hide comment
@dnf-bot

dnf-bot Oct 18, 2016

Member

☀️ Test successful - status-jenkins
Approved by: mluscon
Pushing 5945ec5 to master...

Member

dnf-bot commented Oct 18, 2016

☀️ Test successful - status-jenkins
Approved by: mluscon
Pushing 5945ec5 to master...

@dnf-bot dnf-bot closed this in 5945ec5 Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment