Fix unassigned variable exception in base

[dpindur]

If install_pkgs is empty pkg would never be assigned to and cause an exception when it is passed to _verification_of_packages. A DNF exception would then be raised indicating that some packages have an incorrect checksum.

I noticed this while using the DNF Ansible module. The bug prevented the module from removing packages.

Let me know if you need more details, or can suggest a nicer place to implement the fix.

[dnf-bot]

[flake8]

• [E501] line too long (119 > 100 characters)

[ignatenkobrain]

indeed looks good to me!

Could you please wrap long line? After you fix this, I will merge PR.

[dpindur]

Line wrapped and I think we're all good.

[ignatenkobrain]

@rh-atomic-bot r+

[rh-atomic-bot]

📌 Commit 404503b has been approved by ignatenkobrain

[rh-atomic-bot]

⌛ Testing commit 404503b with merge f82ce2e...

[rh-atomic-bot]

💥 Test timed out

[j-mracek]

@rh-atomic-bot r-

[j-mracek]

This is incorrect fix.

[j-mracek]

Please the original code was little bit more problematic, that is visible on the first look, therefore it has to be little bit more improved.

[j-mracek]

Correct line would be:

if not _verification_of_packages(local_repository_pkgs, msg):

[j-mracek]

I try to little bit improve the code but I didn't test it. Please can you take a look and if you will like it, just use it.

diff --git a/dnf/base.py b/dnf/base.py
index 970f3003..515e2b9c 100644
--- a/dnf/base.py
+++ b/dnf/base.py
@@ -2285,11 +2285,18 @@ class Base(object):
         :return: list of remote pkgs
         """
         def _verification_of_packages(pkg_list, logger_msg):
+            all_packages_verified = True
             for pkg in pkg_list:
-                if not pkg.verifyLocalPkg():
-                    logger.critical(logger_msg)
-                    return False
-            return True
+                pkg_successfully_verified = False
+                try:
+                    pkg_successfully_verified = pkg.verifyLocalPkg()
+                except Exception as e:
+                    logger.critical(str(e))
+                if not pkg_successfully_verified:
+                    logger.critical(logger_msg.format(pkg, pkg.reponame))
+                    all_packages_verified = False
+
+            return all_packages_verified
 
         remote_pkgs = []
         local_repository_pkgs = []
@@ -2299,17 +2306,9 @@ class Base(object):
                     local_repository_pkgs.append(pkg)
             else:
                 remote_pkgs.append(pkg)
-        error = False
-
-        try:
-            msg = _('Package "{}" from local repository "{}" has incorrect checksum')
-            if not _verification_of_packages(local_repository_pkgs, msg.format(pkg, pkg.reponame)):
-                error = True
-        except Exception as e:
-            logger.critical(str(e))
-            error = True
 
-        if error:
+        msg = _('Package "{}" from local repository "{}" has incorrect checksum')
+        if not _verification_of_packages(local_repository_pkgs, msg):
             raise dnf.exceptions.Error(
                 _("Some packages from local repository have incorrect checksum"))

[j-mracek]

@dpindur I added my requested changes in additional commit to yours and create a new pull-request #956. Unfortunately it looks like that others hit the same issue, therefore I just want to speed up the review. Thank you very much for your contribution.

I am closing PR.