Modify solver_describe_decision to report cleaned (RhBug:1486749) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important!!! it requires upstream version of libsolv - may be 0.6.30 |
jrohel
requested changes
Sep 22, 2017
libdnf/hy-goal.c
Outdated
| @@ -1381,7 +1381,7 @@ hy_goal_get_reason(HyGoal goal, DnfPackage *pkg) | |||
| //solver_get_recommendations | |||
| if (goal->solv == NULL) | |||
| return HY_REASON_USER; | |||
| Id info; | |||
| Id info, pkg_id; | |||
| int reason = solver_describe_decision(goal->solv, dnf_package_get_id(pkg), &info); | |||
There was a problem hiding this comment.
Small optimalization :-) Call dnf_package_get_id(pkg) only once.
const Id pkg_id = dnf_package_get_id(pkg);
Id info;
int reason = solver_describe_decision(goal->solv, pkg_id, &info);
and remove line 1399 pkg_id = dnf_package_get_id(pkg);
libdnf/hy-goal.c
Outdated
| queue_free(&cleandepsq); | ||
| return HY_REASON_CLEAN; | ||
| } | ||
| } | ||
| return HY_REASON_DEP; |
There was a problem hiding this comment.
Memory leak. Missing queue_free(&cleandepsq); before return.
If the package in cleandeps it will return SOLVER_REASON_CLEANDEPS_ERASE. https://bugzilla.redhat.com/show_bug.cgi?id=1486749
jrohel
approved these changes
Sep 25, 2017
|
📌 Commit f366c03 has been approved by |
|
☀️ Test successful - status-papr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package in cleandeps it will return SOLVER_REASON_CLEANDEPS_ERASE.
https://bugzilla.redhat.com/show_bug.cgi?id=1486749