New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache directory if librepo supports it #478

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jdieter

jdieter commented Jun 13, 2018

This allows libdnf to take advantage of zchunked repodata

@jdieter jdieter referenced this pull request Jun 13, 2018

Closed

Zchunk support for dnf #1107

@j-mracek

This comment has been minimized.

Contributor

j-mracek commented Jun 15, 2018

It looks nice, but we cannot merge it before dnf-3.0 release. But don't worry after dnf-3.0 dnf releas there will be releases pretty often.

@Conan-Kudo

This comment has been minimized.

Member

Conan-Kudo commented Jun 15, 2018

@j-mracek Why is that?

@Conan-Kudo

This comment has been minimized.

Member

Conan-Kudo commented Jun 15, 2018

@j-mracek This codepath is dead if the librepo PR isn't part of the librepo library at compile time, so it's totally fine to merge.

@jdieter

This comment has been minimized.

jdieter commented Jun 15, 2018

Will libdnf-3.0 be in Fedora 29? I'm hoping (though it might be ambitious) to get zchunk support into Fedora 29, so I'd really love for this patch to be merged in time for that, if it's at all possible.

@dmach

This comment has been minimized.

Contributor

dmach commented Jun 26, 2018

We need to get existing work released in the first place - that's DNF 3.0.
This patch will make it into DNF 3.1, that will be released most likely soon after 3.0.
We'll do our best to get this into F29.

@Conan-Kudo

This comment has been minimized.

Member

Conan-Kudo commented Aug 24, 2018

@jdieter This needs to be reworked to also account for the new repo class that was just merged in #449.

@jdieter

This comment has been minimized.

jdieter commented Sep 28, 2018

Ok, this has been reworked and should work perfectly.

jdieter added some commits Jun 13, 2018

Set cache directory if librepo supports it
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Add option zchunk to decide whether zchunk is used
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment