Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable zchunk so LRO_SUPPORTS_CACHEDIR works #777

Closed

Conversation

@jdieter
Copy link
Contributor

commented Aug 24, 2019

jdieter added 2 commits Aug 24, 2019
Explicitly enable zchunk so LRO_SUPPORTS_CACHEDIR works
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Update spec file
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
libdnf.spec Outdated Show resolved Hide resolved
libdnf.spec Outdated Show resolved Hide resolved
WITH_ZCHUNK defaults to ON
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
@jdieter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

Ok, @Conan-Kudo, done. Please let me know if there's anything else.

libdnf.spec Outdated Show resolved Hide resolved
Use pkgconfig(zck) rather than zchunk-devel
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
@Conan-Kudo

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@jdieter Don't we need zchunk libraries linking into libdnf? If so, then libdnf/CMakeLists.txt needs changes.

@jdieter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

No, they're not actually linked in. We just need the headers from zchunk-devel because we include librepo.h which includes zck.h if WITH_ZCHUNK is defined.

@jdieter

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Is there anything else that needs to be done with this? @Conan-Kudo, if you're happy with this, I'd greatly appreciate a +1. I'd like to get this merged ASAP so zchunk works again in Fedora 30, 31 and Rawhide.

@Conan-Kudo

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@rh-atomic-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

📌 Commit a48391a has been approved by Conan-Kudo

@rh-atomic-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

⌛️ Testing commit a48391a with merge 6a26321...

rh-atomic-bot added a commit that referenced this pull request Sep 3, 2019
Update spec file
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>

Closes: #777
Approved by: Conan-Kudo
rh-atomic-bot added a commit that referenced this pull request Sep 3, 2019
WITH_ZCHUNK defaults to ON
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>

Closes: #777
Approved by: Conan-Kudo
rh-atomic-bot added a commit that referenced this pull request Sep 3, 2019
Use pkgconfig(zck) rather than zchunk-devel
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>

Closes: #777
Approved by: Conan-Kudo
@rh-atomic-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

☀️ Test successful - status-papr
Approved by: Conan-Kudo
Pushing 6a26321 to master...

@jdieter

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.