Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store file descriptor of the logger file (RhBug:1594016) #792

Merged
merged 1 commit into from Sep 10, 2019

Conversation

j-mracek
Copy link
Member

@j-mracek j-mracek merged commit 318c5d9 into rpm-software-management:master Sep 10, 2019
@j-mracek
Copy link
Member Author

I am really sorry, but I do not know how the merge was pushed.

@lukash
Copy link
Contributor

lukash commented Sep 11, 2019

Well 🙂

One think I would welcome is some description of what this is meant to do.

So, the sack_dealloc is being called correctly, but the log_out pointer wasn't stored, so it couldn't close it, right?

Retroactively, LGTM.

But, it doesn't seem great that the logging FD is opened multiple times per one run of the application depending on how the sack is used. It should be opened once in the beginning and closed at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants