Use libsolv selection for filtering DepSolvables (RhBug:1812596) #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot use pool_whatmatchessolvable because it considers only installable solvables, which means source rpms are ignored. https://bugzilla.redhat.com/show_bug.cgi?id=1812596
|
📌 Commit 3a880fd has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 18, 2020
We cannot use pool_whatmatchessolvable because it considers only installable solvables, which means source rpms are ignored. https://bugzilla.redhat.com/show_bug.cgi?id=1812596 Closes: #914 Approved by: Conan-Kudo
|
💔 Test failed - status-papr |
|
one unrelated test failed: |
|
Just came across this, sorry about the inconvenience 😒 However, @Conan-Kudo, when merging, could I ask to always merge together with the tests that come along with it? The tests PR is still unmerged: rpm-software-management/ci-dnf-stack#807 I understand reviewing the tests is additional work and requires some understanding of the CI stack component. And while you can run the tests yourself (in e.g. podman), it certainly is a big hassle... But is there a way around it? For that matter, when doing reviews, we should require tests to be provided for the new code, unless not feasible for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use pool_whatmatchessolvable because it considers only
installable solvables, which means source rpms are ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=1812596
Tests:
rpm-software-management/ci-dnf-stack#807
rpm-software-management/ci-dnf-stack#805 (This one is required, meaning without this fix the tests will be failing)