Handle webservers that don't support ranges when downloading zck #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we fall back to downloading full zchunk file if a webserver doesn't support ranges. Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
|
Tested locally. Thanks Jonathan. |
kontura
added a commit
to kontura/librepo
that referenced
this pull request
Oct 26, 2020
Make sure we fall back to downloading full zchunk file because FTP doesn't support ranges. This is in principle similar situation to rpm-software-management#155 = changelog = msg: When zchunk enabled and using FTP mirror donwload the whole file type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1886706
kontura
added a commit
to kontura/librepo
that referenced
this pull request
Oct 29, 2020
…(RhBug:1886706) Make sure we fall back to downloading full zchunk file because for example FTP doesn't support ranges. This is in principle similar situation to rpm-software-management#155 = changelog = msg: When zchunk enabled and not using HTTP/S protocol donwload the whole file type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1886706
Conan-Kudo
pushed a commit
that referenced
this pull request
Nov 17, 2020
…(RhBug:1886706) Make sure we fall back to downloading full zchunk file because for example FTP doesn't support ranges. This is in principle similar situation to #155 = changelog = msg: When zchunk enabled and not using HTTP/S protocol donwload the whole file type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1886706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we fall back to downloading full zchunk file if a webserver doesn't support ranges. Current code just fails to next mirror.