Do not unref LrErr_Exception on exit (RhBug:1778854) #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the reference to a Python exception obtained from PyErr_NewException is borrowed and is not meant to be decref'd on exit. From valgrind output Python frees the memory allocated for these itself. https://bugzilla.redhat.com/show_bug.cgi?id=1778854
lukash
force-pushed
the
exception-unref
branch
from
3b116a9
to
c7d2f38
Compare
Conan-Kudo
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the reference to a Python exception obtained from
PyErr_NewException is borrowed and is not meant to be unreferenced on
exit. From valgrind output Python frees the memory allocated for these
itself.
https://bugzilla.redhat.com/show_bug.cgi?id=1778854