mockbuild/buildroot: Make btrfs-control available if host supports it #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide125
suggested changes
Jul 11, 2020
Conan-Kudo
force-pushed
the
add-btrfs-control-device
branch
from
8e24e78
to
c92834e
Compare
|
@Conan-Kudo Pavel is on holiday for remaining of the week. I will do the review. Will be the release next week sufficient? Or do you need it sooner? |
|
Sooner, unfortunately. This is one of the things making it impossible to image builds using Btrfs on the target root filesystem. |
xsuchy
reviewed
Jul 20, 2020
|
Beside that permission, LGTM. |
In order to be able to successfully build images properly inside of mock using btrfs filesystems, we need the btrfs-control device to exist. However, we also need mock to gracefully ignore this if the host does not support Btrfs and does not provide the btrfs-control device.
Conan-Kudo
force-pushed
the
add-btrfs-control-device
branch
from
c92834e
to
31740bf
Compare
xsuchy
approved these changes
Jul 21, 2020
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to successfully build images properly inside of mock
using btrfs filesystems, we need the btrfs-control device to exist.
However, we also need mock to gracefully ignore this if the host does
not support Btrfs and does not provide the btrfs-control device.