Move Fedora's brp-mangle-shebangs from fedora-python/brp-mangle-shebangs #2
Conversation
|
@hroncok We probably won't use Travis CI here. RPM itself uses Semaphore CI, and we will likely do the same for this. |
|
Whatever CI you want. Just please have some. Our repo had it and I'm moving this here as requested in https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/31 |
|
@hroncok You know this repo isn't packaged, right? |
|
yes, the file lives in dist git of redhat-rpm-config. I just happen to have tests for it that nobody wants, so I created my own "upstream" and wanted a link to that upstream in redhat-rpm-config spec, so whoever changes the brp script is aware of the tests, but the link was rejected, such scripts already have a repo and that is this one. All I really want is a place where the tests can be and than a link in the spec that links to them + a place where people can send changes and have the tests be run. |
|
@hroncok Other than the Travis CI commit, this looks fine to me. Can you please remove the Travis CI commit and rebase on current master? |
hroncok
force-pushed
the
brp-mangle-shebangs
branch
from
7e7ee3d
to
d015930
Compare
|
Like this or even more rebasing? Note that it will not be trivial (there are files that conflict before I move them around, so I'd need to filter branch or something). |
hroncok
changed the title
|
@hroncok Basically, |
hroncok
force-pushed
the
brp-mangle-shebangs
branch
from
d015930
to
08198ff
Compare
|
Rebased manually commit by commit. Better now? |
|
Actually, wait a minute or five. |
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Reported-by: Jun Aruga <jaruga@redhat.com> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1541057 Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Introduces __brp_mangle_shebangs_exclude_from and __brp_mangle_shebangs_exclude * the first allows to explude specific paths from the mangling * the second allows to exlude specific shebangs Both are used with `grep -E`. Similar escaping rules as in [1] apply. [1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
Now it starts requiring bash instead of POSIX-compatible shell, but this is not a problem since other scripts in here do same. Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
This patch adds two additional rpm macros, __brp_mangle_shebangs_exclude_file and __brp_mangle_shebangs_exclude_from_file, to specify files from which to read the extended regexps used for excluding shebangs and target files. Additionally, this adds documentation in the macros file and --help/--usage/-?/-h to brp-mangle-shebangs, so that it's possible to actually discover what the intended behavior is without reading the script itself. Signed-off-by: Peter Jones <pjones@redhat.com>
hroncok
force-pushed
the
brp-mangle-shebangs
branch
from
08198ff
to
05eee24
Compare
|
This is as good as it gets. |
|
@hroncok Merged, thanks! |
Also, please activate Travis CI for this repository.