`rpm --all --setperms --setugids` doesn't work in v4.20.1

[dmnks]

Originally filed in Fedora Bugzilla:

When I tried running sudo rpm --all --setperms --setugids it doesn't work, no output even with the --verbose flag. It works when I specify a package name, but not with all installed packages by using the --all flag. This occurs with the latest rpm v4.20.1.

It works with rpm v4.20.0 of the stable repo as expected.

Reproducible: Always

Steps to Reproduce:

1. Run sudo rpm --all --setperms --setugids

Actual Results:
No output. Nothing.

Expected Results:
RPM should reset the permissions and user/group ownership files of all installed packages.

[dmnks]

Bisected down to commit cf78319.

[pmatilai]

Well that was surprising 😄

But after a brief look into how the restore was implemented (having forgotten all about the details) it's obvious enough: rpmtsAddRestoreElement() is now returning an error for gpg-pubkey "packages" and because of that error is reflected in rpmcliArgIter() return, we skip the whole transaction. Silently.

So, we'll need to filter out the gpg-pubkey items, and we should have an error message in we need an error message in handleRestorePackage() as well just so actual failures are not silent.

[snowyyd]

Good catch!
We were talking about the same thing in the Fedora forums, when answering a question involving the use of this command. Thanks for pointing that out!

[pmatilai]

Yep. Also worth noting here is that --setperms and --setugids were always hacky and a bit dangerous, and obsolete now. --restore is what is what you should use, and what --setperms and --setugids actually alias to now.