--hash and --percent not allowed for --restore

[pmatilai]

# rpm -vh --restore gmp
rpm: --hash (-h) may only be specified during package installation and erasure
# rpm -v --percent --restore gmp
rpm: --percent may only be specified during package installation and erasure

This is just an oversight when adding --restore, hashes and percents should be allowed here just as they are for install/erase.

[ffesti]

https://github.com/rpm-software-management/rpm/blob/master/tools/rpm.cc#L111 should probably also use the MODES_IER for the second || term. Otoh this condition can't be true in the current code and we might want to juts drop it completely.

There is also the question if there are a few other options that should be allows for --restore. Candidates might be

• --relocate
• --excludepath
• --prefix
• --excludedocs/--includedocs
• --ignoreos
• --allmatches
• --allfiles
• --no script options
• --test

basically most --install options

[pmatilai]

Nope, most of those do not apply for --restore because relocations and file exclusions do not apply at all, --restore is more like --erase than --install in many aspects, but, --allmatches does not apply because it always processes all matches, unlike --erase. Also no scripts are executed on --restore, and so on. It's this rather peculiar mix of characteristics between several different modes.

Of that list, only --test is applicable to --restore.

[ffesti]

OK; added --test only