Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize verifyFlags for specialdir #656

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@bmwiedemann
Copy link
Contributor

commented Apr 4, 2019

Initialize verifyFlags for specialdir, because
FileEntryFree(&fl->cur) zeroed all fields, including verifyFlags, so we have to fill them again.

Closes issue #655

Note: only slightly tested

Initialize verifyFlags for specialdir
FileEntryFree(&fl->cur) zeroed all fields, so we have to fill them again.

Closes issue #655

@pmatilai pmatilai self-requested a review Apr 8, 2019

@pmatilai

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

The pre-existing line seemed looked a little odd there so I dug up history a bit. The line added here was intentionally removed (instead of fixing the typo) in commit bde88ad, but I'm not so sure about the rationale now: current flags are copied everywhere else so why not here?

Anyway, this clearly fixes the verify flags thing, doesn't affect anything else that I can see, and makes things more consistent so it's probably the right thing to do.

@pmatilai
Copy link
Contributor

left a comment

What I said above...

@pmatilai pmatilai merged commit 9668639 into rpm-software-management:master Apr 8, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details
@pmatilai

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Oh and thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.