Initialize verifyFlags for specialdir #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEntryFree(&fl->cur) zeroed all fields, so we have to fill them again. Closes issue rpm-software-management#655
|
The pre-existing line seemed looked a little odd there so I dug up history a bit. The line added here was intentionally removed (instead of fixing the typo) in commit bde88ad, but I'm not so sure about the rationale now: current flags are copied everywhere else so why not here? Anyway, this clearly fixes the verify flags thing, doesn't affect anything else that I can see, and makes things more consistent so it's probably the right thing to do. |
|
Oh and thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Initialize verifyFlags for specialdir, because
FileEntryFree(&fl->cur) zeroed all fields, including verifyFlags, so we have to fill them again.
Closes issue #655
Note: only slightly tested