Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set RPMTAG_BUILDTIME to SOURCE_DATE_EPOCH when defined by default #785

Conversation

@Conan-Kudo
Copy link
Member

commented Jul 7, 2019

Since b8a54d6, when SOURCE_DATE_EPOCH is set, RPMTAG_BUILDTIME winds up being set with that value. This is not always desirable, particularly if you are using the build time for filters and evaluation in certain types of package release pipelines.

This is an adaptation of the downstream patch in SUSE's rpm package written by @mlschroe intended to address SuseBug:1087065 (private bug 馃槩).

@Conan-Kudo

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

@pmatilai, @ffesti, please cherry-pick this into the RPM 4.15 tree.

@Conan-Kudo

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

@pmatilai, @ffesti: I really only have one question here... Do we want to preserve the behavior we introduced in RPM 4.14? Or should I set the value of the new macro to zero by default, and let people turn on the knobs as they want?

@ignatenkobrain

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Or should I set the value of the new macro to zero by default, and let people turn on the knobs as they want?

This would be more logical... And since 4.15 is not released, we can write about this in release notes that we are changing this default behavior.

@Conan-Kudo Conan-Kudo force-pushed the Conan-Kudo:source-date-epoch-buildtime-control branch from 8168b17 to 3b7c37c Jul 7, 2019

@Conan-Kudo

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

@ignatenkobrain Changed.

Do not set RPMTAG_BUILDTIME to SOURCE_DATE_EPOCH when defined by default
Since b8a54d6, when SOURCE_DATE_EPOCH
is set, RPMTAG_BUILDTIME winds up being set with that value. This is
not always desirable, particularly if you are using the build time for
filters and evaluation in certain types of package release pipelines.

This is an adaptation of the downstream patch in SUSE's rpm package
written by Michael Schroeder intended to address SuseBug:1087065.

@Conan-Kudo Conan-Kudo force-pushed the Conan-Kudo:source-date-epoch-buildtime-control branch from 3b7c37c to 0085c20 Jul 7, 2019

@Conan-Kudo Conan-Kudo changed the title Permit RPMTAG_BUILDTIME to not be set to SOURCE_DATE_EPOCH Do not set RPMTAG_BUILDTIME to SOURCE_DATE_EPOCH when defined by default Jul 7, 2019

@ffesti ffesti added this to the 4.15.0 milestone Jul 8, 2019

@ffesti ffesti merged commit 4b15a9e into rpm-software-management:master Jul 8, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details

@Conan-Kudo Conan-Kudo deleted the Conan-Kudo:source-date-epoch-buildtime-control branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.