Do not set RPMTAG_BUILDTIME to SOURCE_DATE_EPOCH when defined by default #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be more logical... And since 4.15 is not released, we can write about this in release notes that we are changing this default behavior. |
Conan-Kudo
force-pushed
the
source-date-epoch-buildtime-control
branch
from
8168b17
to
3b7c37c
Compare
|
@ignatenkobrain Changed. |
Since b8a54d6, when SOURCE_DATE_EPOCH is set, RPMTAG_BUILDTIME winds up being set with that value. This is not always desirable, particularly if you are using the build time for filters and evaluation in certain types of package release pipelines. This is an adaptation of the downstream patch in SUSE's rpm package written by Michael Schroeder intended to address SuseBug:1087065.
Conan-Kudo
force-pushed
the
source-date-epoch-buildtime-control
branch
from
3b7c37c
to
0085c20
Compare
Conan-Kudo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Since b8a54d6, when
SOURCE_DATE_EPOCHis set,RPMTAG_BUILDTIMEwinds up being set with that value. This is not always desirable, particularly if you are using the build time for filters and evaluation in certain types of package release pipelines.This is an adaptation of the downstream patch in SUSE's rpm package written by @mlschroe intended to address SuseBug:1087065 (private bug😢 ).