Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'string' into query format extensions in man-pages #837

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@pavlinamv
Copy link
Contributor

pavlinamv commented Sep 14, 2019

No description provided.

@pmatilai

This comment has been minimized.

Copy link
Contributor

pmatilai commented Sep 17, 2019

Might want to note that this is also the default format, so using it is generally redundant.

@pavlinamv

This comment has been minimized.

Copy link
Contributor Author

pavlinamv commented Sep 17, 2019

Yes, there is no need to use ":string". But it is supported.

@pmatilai

This comment has been minimized.

Copy link
Contributor

pmatilai commented Sep 18, 2019

Yes, and I'm asking that you mention it is the default format to make people aware that it's something they don't need to use. It's basically a side-effect of a code cleanup (in commit 2bfc0fa), not something that ever needed using or advertising.

@pavlinamv

This comment has been minimized.

Copy link
Contributor Author

pavlinamv commented Sep 20, 2019

Mentioning ":string" in that part of man page, will not cause any problems. But if ":string" is not there, it looks like that it is not supported.

@pmatilai

This comment has been minimized.

Copy link
Contributor

pmatilai commented Sep 20, 2019

Ehm. I'm not arguing against this addition. I just ask that while we're at it, you also document that it's the default format! A simple "(default)" would do. I sure don't want to do another pull request just to add that! This is already way too much time wasted over such a petty matter.

@pavlinamv pavlinamv force-pushed the pavlinamv:stringmissing branch from c1edbd6 to e9d4397 Sep 20, 2019
@pmatilai

This comment has been minimized.

Copy link
Contributor

pmatilai commented Sep 20, 2019

Thanks.

@pmatilai pmatilai merged commit cead442 into rpm-software-management:master Sep 20, 2019
1 check passed
1 check passed
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.