Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve processing order in file classification #936

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@pmatilai
Copy link
Contributor

pmatilai commented Nov 11, 2019

The order of file classification isn't interesting in itself, but arbitrary
order makes contents of RPMTAG_CLASSDICT non-deterministic which is not
nice for reproducable builds. Tell OMP to handle the class dictionary
in order.

Cancellation points are not allowed in ordered construct so we need to
drop that. It doesn't change the actual results, just means that we run
a little longer in case errors are encountered.

Fixes #934

The order of file classification isn't interesting in itself, but arbitrary
order makes contents of RPMTAG_CLASSDICT non-deterministic which is not
nice for reproducable builds. Tell OMP to handle the class dictionary
in order.

Cancellation points are not allowed in ordered construct so we need to
drop that. It doesn't change the actual results, just means that we  run
a little longer in case errors are encountered.

Fixes #934
Copy link
Contributor

bmwiedemann left a comment

Tested with this patch and got bit-reproducible results again. Thanks!

@pmatilai

This comment has been minimized.

Copy link
Contributor Author

pmatilai commented Nov 12, 2019

Ack, thanks for testing!

@pmatilai pmatilai merged commit 3691d99 into rpm-software-management:master Nov 12, 2019
3 checks passed
3 checks passed
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
semaphoreci The build passed on Semaphore.
Details
@pmatilai pmatilai deleted the pmatilai:fcorder-pr branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.