Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence spurious error message from lsetfilecon() on -EOPNOTSUPP #976

Merged
merged 1 commit into from Dec 13, 2019

Conversation

pmatilai
Copy link
Member

We already filter out -EOPNOTSUPP and return OK, but the message was
getting logged before the filtering so we'd spit out spurious error
messages on filesystems that don't support SELinux (RhBug:1777502)

We already filter out -EOPNOTSUPP and return OK, but the message was
getting logged before the filtering so we'd spit out spurious error
messages on filesystems that don't support SELinux (RhBug:1777502)
@pmatilai pmatilai added the bug label Dec 13, 2019
@ffesti ffesti merged commit 4a71a3e into rpm-software-management:master Dec 13, 2019
@pmatilai pmatilai deleted the selinux-notsupp-pr branch January 8, 2020 13:09
@ckujau
Copy link

ckujau commented May 1, 2020

Thank you for fixing this. I have a question though: why does this "hide" the error message from lsetfilecon instead of tweaking the routine to not execute lsetfilecon on file systems that do not support SELinux attributes? Is it unwieldy to conditionally execute lsetfilecon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants