TagsCheck: handle license exception in grouping #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A valid license exception which is in a grouping is reported as invalid.
This is due to the trailing ')' being included in the regex. The
following license:
(GPL-2.0-only OR GPL-3.0-only WITH Qt-GPL-exception-1.0) AND MIT
returns:
W: invalid-license-exception Qt-GPL-exception-1.0)
Adjust the license_exception_regex to exclude trailing parenthesis.
Fixes: https://bugzilla.redhat.com/2175241
|
I'm not terribly familiar with writing tests for rpmlint, so please let me know if the added test should be adjusted. |
marxin
requested changes
Mar 6, 2023
There was a problem hiding this comment.
Can you please provide a spec file you used for valid-exception-in-grouping-1.0-1.src.rpm? I would like to upload it to the currently used repository: https://build.opensuse.org/project/show/devel:openSUSE:Factory:rpmlint:tests
|
Apart from that, I'm fine with the change. |
|
Sure, I extracted it from the src.rpm which is part of the change. I used an source instead of a binary rpm to ensure it could be easily reproduced and/or extracted. :) valid-exception-in-grouping.spec.txt (it has a .txt extension because GitHub is dumb.) |
|
Thank you @tmzullinger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A valid license exception which is in a grouping is reported as invalid. This is due to the trailing ')' being included in the regex. The following license:
returns:
Adjust the license_exception_regex to exclude trailing parenthesis.
Fixes: https://bugzilla.redhat.com/2175241