Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test filter into --testwith and --testwithout #28

Closed
jimbair opened this issue Aug 14, 2019 · 4 comments

Comments

@jimbair
Copy link

commented Aug 14, 2019

Instead of having users specify a "!test" syntax to exclude tests, let's try something like --testwith and --testwithout (or whatever sounds good). The switches should be mutually exclusive, meaning you can tell rpminspect to exclude 1 or more tests and run the remaining tests, or you explicitly say which tests you want run.

@dcantrell

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

This makes more sense. I am using -T now, which I would like to use to specify the tests to perform. What about -W for tests to exclude? But I'm also not sure about this wording. Thoughts?

@dcantrell dcantrell self-assigned this Aug 14, 2019

@jimbair

This comment has been minimized.

Copy link
Author

commented Aug 14, 2019

That sounds good to me; the only other thought I had was -T for tests and -E for --excludes; though I don't have any dogs in this particular fight. =)

@dcantrell

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

OK, -T and -E it is. Working on the patch.

dcantrell added a commit that referenced this issue Aug 22, 2019
Split the -T option functionality in to -T and -E (#28)
The purpose of this change is to avoid the \!testname syntax to exclude
a test from an rpminspect run.  By default, all tests that apply will
run.  There are now the -T and -E options:

If you specify -T, then all tests are disabled by default and only the
tests you specify on this option are enabled.  You can pass "-T ALL" to
enable all tests, but that is the default behavior.

If you specify -E, then all tests are enabled by default and only the
tests you specify on this option are disabled.  You can pass "-E ALL" to
disable all tests, but that is sort of pointless because rpminspect ends
up doing nothing.

The options cannot be used together.  The man page and README have been
updated.
@dcantrell

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

The purpose of this change is to avoid the !testname syntax to exclude a test from an rpminspect run. By default, all tests that apply will run. There are now the -T and -E options:

If you specify -T, then all tests are disabled by default and only the tests you specify on this option are enabled. You can pass "-T ALL" to enable all tests, but that is the default behavior.

If you specify -E, then all tests are enabled by default and only the tests you specify on this option are disabled. You can pass "-E ALL" to disable all tests, but that is sort of pointless because rpminspect ends
up doing nothing.

The options cannot be used together. The man page and README have been updated.

@dcantrell dcantrell closed this Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.