Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Gem version should be bumped for wicked_pdf support #4

Closed
wants to merge 1 commit into from

5 participants

@camdez

Gem version should be bumped so that wicked_pdf users have a minimum version they can count on for wicked_pdf support.

Apologies on not thinking of this before.

@nat

Hi I want to write and support this pull request of camdez'. His fix addresses a particular issue that I've been having as well. Thank you!

@nat

Also you'll see more of the rationale for this request here:
camdez#1

Thanks!

@nat

As further clarification. When I am using Heroku cedar with my particular heroku app, when I use the gem you've released it breaks the load and I cannot load any of my heroku instances where it's included. And Camdez' fix works for me perfectly (it's what I'm using), but yours is superior because it's a gem and just 11MB compared to Camdez' which is 34 MB because for some reason when I use gem "wkhtmltopdf-heroku", :git => 'git://github.com/camdez/wkhtmltopdf-heroku.git' in bundler, heroku includes the .git repository.

I've corresponded with Heroku support and pointed them to our discussions and their exact response/fix was:
"Hopefully opening up these issues will encourage the maintainers to update the gem releases."

Thanks for your great gem. I'm sure you are busy and hope you can do this!
Sincerely,
Nathan wharton

@bradphelan
Collaborator

I've bumped the version to 1.0 but it's pusing to rubygems.org at the moment. Hopefully it completes.

@nat

Brad, I think I just attempted to push your update to Heroku but it seemed to crash my application, still. I haven't had time to debug it fully.. not sure if it's just because rubygems wasn't updated or not. Thanks!

@cdwort

@camdez @nat Some of the issues with wkhtmltopdf-heroku have been affecting PDFKit, so we've forked this repo under the PDFKit org. If this is still an problem for you, please open an issue at https://github.com/pdfkit/wkhtmltopdf-heroku/

Thanks!

@pallymore pallymore closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 23, 2012
  1. @camdez
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +1 −1  VERSION
  2. +2 −2 wkhtmltopdf-heroku.gemspec
View
2  VERSION
@@ -1 +1 @@
-0.1.3
+0.2.0
View
4 wkhtmltopdf-heroku.gemspec
@@ -5,11 +5,11 @@
Gem::Specification.new do |s|
s.name = %q{wkhtmltopdf-heroku}
- s.version = "0.1.3"
+ s.version = "0.2.0"
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
s.authors = [%q{Brad Phelan}]
- s.date = %q{2012-01-03}
+ s.date = %q{2012-03-23}
s.description = %q{wkhtmltopdf binaries heroku}
s.email = %q{bradphelan@xtargets.com}
s.executables = [%q{wkhtmltopdf-linux-amd64}]
Something went wrong with that request. Please try again.