Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes legacy APNS replaced with v2 #614

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

benlangfeld
Copy link
Collaborator

The binary interface was shut down by Apple. Fixes #568.

The binary interface was shut down by Apple. Fixes #568.
@aried3r
Copy link
Member

aried3r commented May 6, 2021

Hey @benlangfeld! I realize this is still a draft PR, but I was wondering if we need to rename classes. I'd assume it would make updating just a bit harder and invalidating possible resources (blogs, articles, StackOverflow questions...) on Rpush with APNs2 a little harder to follow.

My opinion would be to leave everything as APNs2 as that's what people would perhaps look for, even though Apple doesn't (to my knowledge) use that name themselves. WDYT?

@benlangfeld
Copy link
Collaborator Author

Hey @benlangfeld! I realize this is still a draft PR, but I was wondering if we need to rename classes. I'd assume it would make updating just a bit harder and invalidating possible resources (blogs, articles, StackOverflow questions...) on Rpush with APNs2 a little harder to follow.

My opinion would be to leave everything as APNs2 as that's what people would perhaps look for, even though Apple doesn't (to my knowledge) use that name themselves. WDYT?

My thought process was around alignment with Apple terminology, as well as avoiding the question "What is Apns1?".

I can stick with the name if you think it's important, though.

@benlangfeld
Copy link
Collaborator Author

It seems Travis has no intention of actually building this. I'm thinking we should switch to Github Actions.

It doesn't mean anything, since this is not Apple terminology nor is there an `Apns1`, but it makes upgrades and stale documentation easier maybe.
@benlangfeld
Copy link
Collaborator Author

I apologise for the noisy commits here, I'm having trouble installing nokogiri locally so depending on CI right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove APNSv1 support
2 participants