New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes legacy APNS replaced with v2 #614
base: master
Are you sure you want to change the base?
Conversation
The binary interface was shut down by Apple. Fixes #568.
Hey @benlangfeld! I realize this is still a draft PR, but I was wondering if we need to rename classes. I'd assume it would make updating just a bit harder and invalidating possible resources (blogs, articles, StackOverflow questions...) on Rpush with APNs2 a little harder to follow. My opinion would be to leave everything as APNs2 as that's what people would perhaps look for, even though Apple doesn't (to my knowledge) use that name themselves. WDYT? |
My thought process was around alignment with Apple terminology, as well as avoiding the question "What is Apns1?". I can stick with the name if you think it's important, though. |
It seems Travis has no intention of actually building this. I'm thinking we should switch to Github Actions. |
It doesn't mean anything, since this is not Apple terminology nor is there an `Apns1`, but it makes upgrades and stale documentation easier maybe.
I apologise for the noisy commits here, I'm having trouble installing nokogiri locally so depending on CI right now. |
The binary interface was shut down by Apple. Fixes #568.