Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Specifying Default Serializer for Django-RQ Queue #626

Closed
sophcass opened this issue Sep 20, 2023 · 2 comments
Closed

Allow Specifying Default Serializer for Django-RQ Queue #626

sophcass opened this issue Sep 20, 2023 · 2 comments

Comments

@sophcass
Copy link
Contributor

sophcass commented Sep 20, 2023

Description

We are currently using django-rq alongside Redis Queue (RQ). In our setup, we've opted to use the JSONSerializer instead of the default pickle serializer. The reason behind this choice is the potential versioning issues that can arise from using pickle.

Details

We've successfully configured our setup to use the JSONSerializer for processing jobs in the queue. However we've run into an issue when it comes to utilising the django-rq admin dashboard while also using the JSONSerializer.

The challenge we face is that django-rq isn't aware of the serializer we've chosen, and as a result, it doesn't specify the serializer when fetching information to be displayed in the admin dashboard. As a result, the dashboard becomes somewhat limited and less useful for us.

The admin dashboard feature was one of the primary reasons we have adopted django-rq, and we are eager to continue leveraging it while also using the JSONSerializer for our jobs.

Proposed Solution

We would like to propose opening a PR to enhance django-rq's functionality. Specifically, to enable users to specify their desired default serializer when they initially set up the Redis queue. This enhancement would simplify our configuration process, ensuring that we don't need to set the serializer in multiple places when setting up the Redis queue via django-rq and also it would allow us to utilise the admin dashboard in conjunction with JSONSerializer.

If you are happy for us to make these changes, we can get to work on a PR to implement them! Let us know!

@sophcass
Copy link
Contributor Author

sophcass commented Nov 3, 2023

@selwin it would be great to hear your thoughts about this proposition, so that we can start working on it.

@selwin
Copy link
Collaborator

selwin commented Nov 26, 2023

Fixed in #630

@selwin selwin closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants