New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change datetime formatting to include milliseconds #721

Closed
samuelcolvin opened this Issue Jun 29, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@samuelcolvin
Member

samuelcolvin commented Jun 29, 2016

I propose '%Y-%m-%dT%H:%M:%SZ' in utcformat becomes '%Y-%m-%dT%H:%M:%S.%fZ', note the %f to give more exact times.

This is because we have numerous jobs with take around a second and are queued for around a second and without started_at and ended_at being saved with ms it's impossible to get a good idea of how long their really taking.

I can see from the comments in utcparse that something similar was previously the case so I wanted to canvas opinions on whether this was a possibility before submitting a PR?

@samuelcolvin

This comment has been minimized.

Show comment
Hide comment
@samuelcolvin
Member

samuelcolvin commented Jun 29, 2016

see code here

@selwin

This comment has been minimized.

Show comment
Hide comment
@selwin

selwin Jul 15, 2016

Collaborator

Yeah, I think this is a good idea. PR welcome :)

Collaborator

selwin commented Jul 15, 2016

Yeah, I think this is a good idea. PR welcome :)

@theodesp

This comment has been minimized.

Show comment
Hide comment
@theodesp

theodesp Sep 5, 2017

Contributor

@samuelcolvin are you willing to make a PR for this?

Contributor

theodesp commented Sep 5, 2017

@samuelcolvin are you willing to make a PR for this?

@samuelcolvin

This comment has been minimized.

Show comment
Hide comment
@samuelcolvin

samuelcolvin Sep 5, 2017

Member

Hi @theodesp, thanks for the prompt, I'd forgotten about this.

I'm submit a PR once #874 is merged.

Member

samuelcolvin commented Sep 5, 2017

Hi @theodesp, thanks for the prompt, I'd forgotten about this.

I'm submit a PR once #874 is merged.

@selwin

This comment has been minimized.

Show comment
Hide comment
@selwin

selwin Sep 5, 2017

Collaborator

@samuelcolvin #874 has been merged 😊. I personally want to see this supported in RQ because this may be useful in collecting worker/job metrics - something I’ll be working on soon.

Collaborator

selwin commented Sep 5, 2017

@samuelcolvin #874 has been merged 😊. I personally want to see this supported in RQ because this may be useful in collecting worker/job metrics - something I’ll be working on soon.

samuelcolvin added a commit to samuelcolvin/rq that referenced this issue Sep 9, 2017

@selwin selwin closed this in #880 Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment