New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom connection class #741

Merged
merged 3 commits into from Aug 23, 2016

Conversation

Projects
None yet
4 participants
@julyclyde
Contributor

julyclyde commented Aug 12, 2016

dependency injection

Show outdated Hide outdated rq/cli/cli.py
if url:
return StrictRedis.from_url(url)
return connection_class.from_url(url)

This comment has been minimized.

@proofit404

proofit404 Aug 12, 2016

attribute error: str does not have attribute from_url.

@proofit404

proofit404 Aug 12, 2016

attribute error: str does not have attribute from_url.

This comment has been minimized.

@julyclyde

julyclyde Aug 12, 2016

Contributor

I should have tested it before PR.

@julyclyde

julyclyde Aug 12, 2016

Contributor

I should have tested it before PR.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 12, 2016

Coverage Status

Coverage increased (+0.02%) to 86.013% when pulling ee4cf6e on rq-cluster:rxl-sentinel into 69b43da on nvie:master.

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.02%) to 86.013% when pulling ee4cf6e on rq-cluster:rxl-sentinel into 69b43da on nvie:master.

@selwin

This comment has been minimized.

Show comment
Hide comment
@selwin

selwin Aug 23, 2016

Collaborator

May I know the rationale behind this change?

Collaborator

selwin commented Aug 23, 2016

May I know the rationale behind this change?

@julyclyde

This comment has been minimized.

Show comment
Hide comment
@julyclyde

julyclyde Aug 23, 2016

Contributor

I want to use RedisCluster class instead.

Contributor

julyclyde commented Aug 23, 2016

I want to use RedisCluster class instead.

@selwin selwin merged commit d267489 into rq:master Aug 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@selwin

This comment has been minimized.

Show comment
Hide comment
@selwin

selwin Aug 23, 2016

Collaborator

@julyclyde alright, merged. Could you please open a PR to gh-pages branch documenting this change with an example on how to use this feature with RedisCluster? I think that will be really useful. I also recently got an inquiry about this rq/django-rq#177

Collaborator

selwin commented Aug 23, 2016

@julyclyde alright, merged. Could you please open a PR to gh-pages branch documenting this change with an example on how to use this feature with RedisCluster? I think that will be really useful. I also recently got an inquiry about this rq/django-rq#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment