Fix serializing proto key#7
Merged
Merged
Conversation
4 tasks
Member
|
Ha yes I just checked the PR and I failed to catch that regression. Thanks for the fix! |
Sytten
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating Javy, our tests noticed a bug with serialization. Our tests noticed an issue with
JSON.parse('{"__proto__":[]}'). The existing code is doing the equivalent ofobj["__proto__"] = []which setsobj's prototype to an array whereas it should remain asObject.prototype. This fix ensures an own property called__proto__is defined withvalueinstead of calling the prototype setter.